[PATCH] D39386: [Power9] Allow gpr callee saved spills in prologue to vector registers rather than stack

Francis Visoiu Mistrih via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 14 02:46:50 PDT 2018


thegameg accepted this revision.
thegameg added a comment.

Please add a MIR test for this, it would make the test much clearer.

Other than that and the comment below, it LGTM!



================
Comment at: lib/Target/PowerPC/PPCFrameLowering.cpp:1972
+
+  for (unsigned Reg = BVAllocatable.find_first(); Reg < BVAllocatable.size();
+       Reg = BVAllocatable.find_next(Reg)) {
----------------
`for (unsigned Reg : BVAllocatable.set_bits())` should be equivalent here.


https://reviews.llvm.org/D39386





More information about the llvm-commits mailing list