[PATCH] D39386: [Power9] Allow gpr callee saved spills in prologue to vector registers rather than stack

[Nemanja Ivanovic via Phabricator via llvm-commits]

nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.

LGTM.
Perhaps @thegameg or @MatzeB want to look at it as well (particularly the target independent parts). And perhaps @hfinkel and @echristo are interested in having another look. Otherwise, I suppose this is ready to go.



================
Comment at: include/llvm/CodeGen/MachineFrameInfo.h:54
+  /// register.
+  bool SpilledToReg = false;
 
----------------
You initialize this in the only constructor. I don't think there's any point in initializing it here.


================
Comment at: lib/CodeGen/PrologEpilogInserter.cpp:474
+    // before it is reloaded in the epilogue. The Visited set contains all
+    // blocks outside the prologue and epilogue.
+    if (CSI[i].isSpilledToReg()) {
----------------
`... outside of the region delimited by the prologue/epilogue.`
I think that's what this comment is meant to say, isn't it?


https://reviews.llvm.org/D39386