[PATCH] D50660: [WebAssembly] SIMD encoding tests

[Thomas Lively via Phabricator via llvm-commits]

tlively added inline comments.


================
Comment at: test/CodeGen/WebAssembly/simd-arith.ll:21
+; SIMD128: i8x16.add $push0=, $0, $1 # encoding: [0xfd,0x18]{{$}}
+; SIMD128: return $pop0 #
 define <16 x i8> @add_v16i8(<16 x i8> %x, <16 x i8> %y) {
----------------
aheejin wrote:
> Do we need `#` at the end here?
Not really. One option is to complete the line `; SIMD128: return $pop0 # encoding: [0x0f]`, Another is to just stop with the `$pop0.` I had added the `#` because the test had previously checked for end of line and I didn't want to weaken the test too much.


Repository:
  rL LLVM

https://reviews.llvm.org/D50660