[PATCH] D50660: [WebAssembly] SIMD encoding tests

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 13 18:07:09 PDT 2018


aheejin added a comment.

Didn't know `llc` has `--show-mc-encoding` option! 👍 Probably we should start using this elsewhere too.



================
Comment at: test/CodeGen/WebAssembly/simd-arith.ll:21
+; SIMD128: i8x16.add $push0=, $0, $1 # encoding: [0xfd,0x18]{{$}}
+; SIMD128: return $pop0 #
 define <16 x i8> @add_v16i8(<16 x i8> %x, <16 x i8> %y) {
----------------
Do we need `#` at the end here?


Repository:
  rL LLVM

https://reviews.llvm.org/D50660





More information about the llvm-commits mailing list