[llvm] r339630 - Revert "[WebAssembly] Added default stack-only instruction mode for MC."

Richard Smith via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 13 18:26:07 PDT 2018


When reverting a patch, please say in the commit message *why* you're
reverting it, and also the SVN revision that you're reverting (SVN is our
version control system of record, not git, so hashes from a git mirror are
much less useful than a revision number).

This revert caused test failures because the cleanup change r339490 that
was made to fix test failures from the original change was not also
reverted. I've reverted that for you in r339635.

On Mon, 13 Aug 2018 at 16:12, Wouter van Oortmerssen via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: aardappel
> Date: Mon Aug 13 16:12:49 2018
> New Revision: 339630
>
> URL: http://llvm.org/viewvc/llvm-project?rev=339630&view=rev
> Log:
> Revert "[WebAssembly] Added default stack-only instruction mode for MC."
>
> This reverts commit 917a99b71ce21c975be7bfbf66f4040f965d9f3c.
>
> Modified:
>     llvm/trunk/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp
>     llvm/trunk/lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp
>     llvm/trunk/lib/Target/WebAssembly/WebAssemblyExplicitLocals.cpp
>     llvm/trunk/lib/Target/WebAssembly/WebAssemblyInstrControl.td
>     llvm/trunk/lib/Target/WebAssembly/WebAssemblyInstrMemory.td
>     llvm/trunk/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp
>     llvm/trunk/test/CodeGen/WebAssembly/address-offsets.ll
>     llvm/trunk/test/CodeGen/WebAssembly/atomic-mem-consistency.ll
>     llvm/trunk/test/CodeGen/WebAssembly/atomic-rmw.ll
>     llvm/trunk/test/CodeGen/WebAssembly/byval.ll
>     llvm/trunk/test/CodeGen/WebAssembly/call.ll
>     llvm/trunk/test/CodeGen/WebAssembly/cfg-stackify-eh.ll
>     llvm/trunk/test/CodeGen/WebAssembly/cfg-stackify.ll
>     llvm/trunk/test/CodeGen/WebAssembly/cfi.ll
>     llvm/trunk/test/CodeGen/WebAssembly/comparisons_f32.ll
>     llvm/trunk/test/CodeGen/WebAssembly/comparisons_f64.ll
>     llvm/trunk/test/CodeGen/WebAssembly/comparisons_i32.ll
>     llvm/trunk/test/CodeGen/WebAssembly/comparisons_i64.ll
>     llvm/trunk/test/CodeGen/WebAssembly/conv-trap.ll
>     llvm/trunk/test/CodeGen/WebAssembly/conv.ll
>     llvm/trunk/test/CodeGen/WebAssembly/copysign-casts.ll
>     llvm/trunk/test/CodeGen/WebAssembly/divrem-constant.ll
>     llvm/trunk/test/CodeGen/WebAssembly/exception.ll
>     llvm/trunk/test/CodeGen/WebAssembly/explicit-locals.mir
>     llvm/trunk/test/CodeGen/WebAssembly/f16.ll
>     llvm/trunk/test/CodeGen/WebAssembly/f32.ll
>     llvm/trunk/test/CodeGen/WebAssembly/f64.ll
>     llvm/trunk/test/CodeGen/WebAssembly/fast-isel-br-i1.ll
>     llvm/trunk/test/CodeGen/WebAssembly/fast-isel-i24.ll
>     llvm/trunk/test/CodeGen/WebAssembly/fast-isel-i256.ll
>     llvm/trunk/test/CodeGen/WebAssembly/fast-isel-noreg.ll
>     llvm/trunk/test/CodeGen/WebAssembly/fast-isel.ll
>     llvm/trunk/test/CodeGen/WebAssembly/frem.ll
>     llvm/trunk/test/CodeGen/WebAssembly/func.ll
>     llvm/trunk/test/CodeGen/WebAssembly/function-bitcasts-varargs.ll
>     llvm/trunk/test/CodeGen/WebAssembly/function-bitcasts.ll
>     llvm/trunk/test/CodeGen/WebAssembly/global.ll
>     llvm/trunk/test/CodeGen/WebAssembly/i128.ll
>     llvm/trunk/test/CodeGen/WebAssembly/i32-load-store-alignment.ll
>     llvm/trunk/test/CodeGen/WebAssembly/i32.ll
>     llvm/trunk/test/CodeGen/WebAssembly/i64-load-store-alignment.ll
>     llvm/trunk/test/CodeGen/WebAssembly/i64.ll
>     llvm/trunk/test/CodeGen/WebAssembly/ident.ll
>     llvm/trunk/test/CodeGen/WebAssembly/immediates.ll
>     llvm/trunk/test/CodeGen/WebAssembly/implicit-def.ll
>     llvm/trunk/test/CodeGen/WebAssembly/import-module.ll
>     llvm/trunk/test/CodeGen/WebAssembly/indirect-import.ll
>     llvm/trunk/test/CodeGen/WebAssembly/inline-asm-m.ll
>     llvm/trunk/test/CodeGen/WebAssembly/inline-asm.ll
>     llvm/trunk/test/CodeGen/WebAssembly/irreducible-cfg.ll
>     llvm/trunk/test/CodeGen/WebAssembly/legalize.ll
>     llvm/trunk/test/CodeGen/WebAssembly/libcalls.ll
>     llvm/trunk/test/CodeGen/WebAssembly/load-ext-atomic.ll
>     llvm/trunk/test/CodeGen/WebAssembly/load-ext.ll
>     llvm/trunk/test/CodeGen/WebAssembly/load-store-i1.ll
>     llvm/trunk/test/CodeGen/WebAssembly/load.ll
>     llvm/trunk/test/CodeGen/WebAssembly/lower-em-ehsjlj-options.ll
>     llvm/trunk/test/CodeGen/WebAssembly/lower-global-dtors.ll
>     llvm/trunk/test/CodeGen/WebAssembly/mem-intrinsics.ll
>     llvm/trunk/test/CodeGen/WebAssembly/memory-addr32.ll
>     llvm/trunk/test/CodeGen/WebAssembly/muloti4.ll
>     llvm/trunk/test/CodeGen/WebAssembly/negative-base-reg.ll
>     llvm/trunk/test/CodeGen/WebAssembly/offset-atomics.ll
>     llvm/trunk/test/CodeGen/WebAssembly/offset-fastisel.ll
>     llvm/trunk/test/CodeGen/WebAssembly/offset-folding.ll
>     llvm/trunk/test/CodeGen/WebAssembly/offset.ll
>     llvm/trunk/test/CodeGen/WebAssembly/phi.ll
>     llvm/trunk/test/CodeGen/WebAssembly/reg-stackify.ll
>     llvm/trunk/test/CodeGen/WebAssembly/return-int32.ll
>     llvm/trunk/test/CodeGen/WebAssembly/returned.ll
>     llvm/trunk/test/CodeGen/WebAssembly/select.ll
>     llvm/trunk/test/CodeGen/WebAssembly/signext-arg.ll
>     llvm/trunk/test/CodeGen/WebAssembly/signext-inreg.ll
>     llvm/trunk/test/CodeGen/WebAssembly/signext-zeroext.ll
>     llvm/trunk/test/CodeGen/WebAssembly/simd-arith.ll
>     llvm/trunk/test/CodeGen/WebAssembly/stack-alignment.ll
>     llvm/trunk/test/CodeGen/WebAssembly/store-trunc-atomic.ll
>     llvm/trunk/test/CodeGen/WebAssembly/store-trunc.ll
>     llvm/trunk/test/CodeGen/WebAssembly/store.ll
>     llvm/trunk/test/CodeGen/WebAssembly/switch.ll
>     llvm/trunk/test/CodeGen/WebAssembly/tls.ll
>     llvm/trunk/test/CodeGen/WebAssembly/umulo-i64.ll
>     llvm/trunk/test/CodeGen/WebAssembly/unsupported-function-bitcasts.ll
>     llvm/trunk/test/CodeGen/WebAssembly/unused-argument.ll
>     llvm/trunk/test/CodeGen/WebAssembly/userstack.ll
>     llvm/trunk/test/CodeGen/WebAssembly/varargs.ll
>     llvm/trunk/test/CodeGen/WebAssembly/vtable.ll
>     llvm/trunk/test/MC/Disassembler/WebAssembly/wasm.txt
>     llvm/trunk/test/MC/WebAssembly/basic-assembly.s
>     llvm/trunk/test/MC/WebAssembly/reloc-code.ll
>     llvm/trunk/test/MC/WebAssembly/weak-alias.ll
>     llvm/trunk/unittests/MC/Disassembler.cpp
>
> Modified:
> llvm/trunk/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp?rev=339630&r1=339629&r2=339630&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp
> (original)
> +++ llvm/trunk/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp
> Mon Aug 13 16:12:49 2018
> @@ -34,10 +34,27 @@ using namespace llvm;
>
>  namespace {
>
> +// We store register types as SimpleValueType to retain SIMD layout
> +// information, but must also be able to supply them as the (unnamed)
> +// register enum from WebAssemblyRegisterInfo.td/.inc.
> +static unsigned MVTToWasmReg(MVT::SimpleValueType Type) {
> +  switch(Type) {
> +    case MVT::i32: return WebAssembly::I32_0;
> +    case MVT::i64: return WebAssembly::I64_0;
> +    case MVT::f32: return WebAssembly::F32_0;
> +    case MVT::f64: return WebAssembly::F64_0;
> +    case MVT::v16i8: return WebAssembly::V128_0;
> +    case MVT::v8i16: return WebAssembly::V128_0;
> +    case MVT::v4i32: return WebAssembly::V128_0;
> +    case MVT::v4f32: return WebAssembly::V128_0;
> +    default: return MVT::INVALID_SIMPLE_VALUE_TYPE;
> +  }
> +}
> +
>  /// WebAssemblyOperand - Instances of this class represent the operands
> in a
>  /// parsed WASM machine instruction.
>  struct WebAssemblyOperand : public MCParsedAsmOperand {
> -  enum KindTy { Token, Integer, Float, Symbol } Kind;
> +  enum KindTy { Token, Local, Stack, Integer, Float, Symbol } Kind;
>
>    SMLoc StartLoc, EndLoc;
>
> @@ -45,6 +62,19 @@ struct WebAssemblyOperand : public MCPar
>      StringRef Tok;
>    };
>
> +  struct RegOp {
> +    // This is a (virtual) local or stack register represented as 0..
> +    unsigned RegNo;
> +    // In most targets, the register number also encodes the type, but for
> +    // wasm we have to track that seperately since we have an unbounded
> +    // number of registers.
> +    // This has the unfortunate side effect that we supply a different
> value
> +    // to the table-gen matcher at different times in the process (when it
> +    // calls getReg() or addRegOperands().
> +    // TODO: While this works, it feels brittle. and would be nice to
> clean up.
> +    MVT::SimpleValueType Type;
> +  };
> +
>    struct IntOp {
>      int64_t Val;
>    };
> @@ -59,6 +89,7 @@ struct WebAssemblyOperand : public MCPar
>
>    union {
>      struct TokOp Tok;
> +    struct RegOp Reg;
>      struct IntOp Int;
>      struct FltOp Flt;
>      struct SymOp Sym;
> @@ -66,6 +97,8 @@ struct WebAssemblyOperand : public MCPar
>
>    WebAssemblyOperand(KindTy K, SMLoc Start, SMLoc End, TokOp T)
>      : Kind(K), StartLoc(Start), EndLoc(End), Tok(T) {}
> +  WebAssemblyOperand(KindTy K, SMLoc Start, SMLoc End, RegOp R)
> +    : Kind(K), StartLoc(Start), EndLoc(End), Reg(R) {}
>    WebAssemblyOperand(KindTy K, SMLoc Start, SMLoc End, IntOp I)
>      : Kind(K), StartLoc(Start), EndLoc(End), Int(I) {}
>    WebAssemblyOperand(KindTy K, SMLoc Start, SMLoc End, FltOp F)
> @@ -77,12 +110,14 @@ struct WebAssemblyOperand : public MCPar
>    bool isImm() const override { return Kind == Integer ||
>                                         Kind == Float ||
>                                         Kind == Symbol; }
> +  bool isReg() const override { return Kind == Local || Kind == Stack; }
>    bool isMem() const override { return false; }
> -  bool isReg() const override { return false; }
>
>    unsigned getReg() const override {
> -    llvm_unreachable("Assembly inspects a register operand");
> -    return 0;
> +    assert(isReg());
> +    // This is called from the tablegen matcher (MatchInstructionImpl)
> +    // where it expects to match the type of register, see RegOp above.
> +    return MVTToWasmReg(Reg.Type);
>    }
>
>    StringRef getToken() const {
> @@ -93,9 +128,19 @@ struct WebAssemblyOperand : public MCPar
>    SMLoc getStartLoc() const override { return StartLoc; }
>    SMLoc getEndLoc() const override { return EndLoc; }
>
> -  void addRegOperands(MCInst &, unsigned) const {
> -    // Required by the assembly matcher.
> -    llvm_unreachable("Assembly matcher creates register operands");
> +  void addRegOperands(MCInst &Inst, unsigned N) const {
> +    assert(N == 1 && "Invalid number of operands!");
> +    assert(isReg() && "Not a register operand!");
> +    // This is called from the tablegen matcher (MatchInstructionImpl)
> +    // where it expects to output the actual register index, see RegOp
> above.
> +    unsigned R = Reg.RegNo;
> +    if (Kind == Stack) {
> +      // A stack register is represented as a large negative number.
> +      // See WebAssemblyRegNumbering::runOnMachineFunction and
> +      // getWARegStackId for why this | is needed.
> +      R |= INT32_MIN;
> +    }
> +    Inst.addOperand(MCOperand::createReg(R));
>    }
>
>    void addImmOperands(MCInst &Inst, unsigned N) const {
> @@ -115,6 +160,12 @@ struct WebAssemblyOperand : public MCPar
>      case Token:
>        OS << "Tok:" << Tok.Tok;
>        break;
> +    case Local:
> +      OS << "Loc:" << Reg.RegNo << ":" << static_cast<int>(Reg.Type);
> +      break;
> +    case Stack:
> +      OS << "Stk:" << Reg.RegNo << ":" << static_cast<int>(Reg.Type);
> +      break;
>      case Integer:
>        OS << "Int:" << Int.Val;
>        break;
> @@ -131,6 +182,11 @@ struct WebAssemblyOperand : public MCPar
>  class WebAssemblyAsmParser final : public MCTargetAsmParser {
>    MCAsmParser &Parser;
>    MCAsmLexer &Lexer;
> +  // These are for the current function being parsed:
> +  // These are vectors since register assignments are so far non-sparse.
> +  // Replace by map if necessary.
> +  std::vector<MVT::SimpleValueType> LocalTypes;
> +  std::vector<MVT::SimpleValueType> StackTypes;
>    MCSymbol *LastLabel;
>
>  public:
> @@ -180,6 +236,68 @@ public:
>          .Default(MVT::INVALID_SIMPLE_VALUE_TYPE);
>    }
>
> +  MVT::SimpleValueType &GetType(
> +      std::vector<MVT::SimpleValueType> &Types, size_t i) {
> +    Types.resize(std::max(i + 1, Types.size()),
> MVT::INVALID_SIMPLE_VALUE_TYPE);
> +    return Types[i];
> +  }
> +
> +  bool ParseReg(OperandVector &Operands, StringRef TypePrefix) {
> +    if (Lexer.is(AsmToken::Integer)) {
> +      auto &Local = Lexer.getTok();
> +      // This is a reference to a local, turn it into a virtual register.
> +      auto LocalNo = static_cast<unsigned>(Local.getIntVal());
> +      Operands.push_back(make_unique<WebAssemblyOperand>(
> +                           WebAssemblyOperand::Local, Local.getLoc(),
> +                           Local.getEndLoc(),
> +                           WebAssemblyOperand::RegOp{LocalNo,
> +                               GetType(LocalTypes, LocalNo)}));
> +      Parser.Lex();
> +    } else if (Lexer.is(AsmToken::Identifier)) {
> +      auto &StackRegTok = Lexer.getTok();
> +      // These are push/pop/drop pseudo stack registers, which we turn
> +      // into virtual registers also. The stackify pass will later turn
> them
> +      // back into implicit stack references if possible.
> +      auto StackReg = StackRegTok.getString();
> +      auto StackOp = StackReg.take_while([](char c) { return isalpha(c);
> });
> +      auto Reg = StackReg.drop_front(StackOp.size());
> +      unsigned long long ParsedRegNo = 0;
> +      if (!Reg.empty() && getAsUnsignedInteger(Reg, 10, ParsedRegNo))
> +        return Error("Cannot parse stack register index: ", StackRegTok);
> +      unsigned RegNo = static_cast<unsigned>(ParsedRegNo);
> +      if (StackOp == "push") {
> +        // This defines a result, record register type.
> +        auto RegType = ParseRegType(TypePrefix);
> +        GetType(StackTypes, RegNo) = RegType;
> +        Operands.push_back(make_unique<WebAssemblyOperand>(
> +                             WebAssemblyOperand::Stack,
> +                             StackRegTok.getLoc(),
> +                             StackRegTok.getEndLoc(),
> +                             WebAssemblyOperand::RegOp{RegNo, RegType}));
> +      } else if (StackOp == "pop") {
> +        // This uses a previously defined stack value.
> +        auto RegType = GetType(StackTypes, RegNo);
> +        Operands.push_back(make_unique<WebAssemblyOperand>(
> +                             WebAssemblyOperand::Stack,
> +                             StackRegTok.getLoc(),
> +                             StackRegTok.getEndLoc(),
> +                             WebAssemblyOperand::RegOp{RegNo, RegType}));
> +      } else if (StackOp == "drop") {
> +        // This operand will be dropped, since it is part of an
> instruction
> +        // whose result is void.
> +      } else {
> +        return Error("Unknown stack register prefix: ", StackRegTok);
> +      }
> +      Parser.Lex();
> +    } else {
> +      return Error(
> +            "Expected identifier/integer following $, instead got: ",
> +            Lexer.getTok());
> +    }
> +    IsNext(AsmToken::Equal);
> +    return false;
> +  }
> +
>    void ParseSingleInteger(bool IsNegative, OperandVector &Operands) {
>      auto &Int = Lexer.getTok();
>      int64_t Val = Int.getIntVal();
> @@ -192,26 +310,36 @@ public:
>
>    bool ParseOperandStartingWithInteger(bool IsNegative,
>                                         OperandVector &Operands,
> -                                       StringRef InstName) {
> +                                       StringRef InstType) {
>      ParseSingleInteger(IsNegative, Operands);
> -    // FIXME: there is probably a cleaner way to do this.
> -    auto IsLoadStore = InstName.startswith("load") ||
> -                       InstName.startswith("store") ||
> -                       InstName.startswith("atomic_load") ||
> -                       InstName.startswith("atomic_store");
> -    if (IsLoadStore) {
> -      // Parse load/store operands of the form: offset align
> -      auto &Offset = Lexer.getTok();
> -      if (Offset.is(AsmToken::Integer)) {
> +    if (Lexer.is(AsmToken::LParen)) {
> +      // Parse load/store operands of the form: offset($reg)align
> +      auto &LParen = Lexer.getTok();
> +      Operands.push_back(
> +            make_unique<WebAssemblyOperand>(WebAssemblyOperand::Token,
> +                                            LParen.getLoc(),
> +                                            LParen.getEndLoc(),
> +                                            WebAssemblyOperand::TokOp{
> +                                              LParen.getString()}));
> +      Parser.Lex();
> +      if (Expect(AsmToken::Dollar, "register")) return true;
> +      if (ParseReg(Operands, InstType)) return true;
> +      auto &RParen = Lexer.getTok();
> +      Operands.push_back(
> +            make_unique<WebAssemblyOperand>(WebAssemblyOperand::Token,
> +                                            RParen.getLoc(),
> +                                            RParen.getEndLoc(),
> +                                            WebAssemblyOperand::TokOp{
> +                                              RParen.getString()}));
> +      if (Expect(AsmToken::RParen, ")")) return true;
> +      if (Lexer.is(AsmToken::Integer)) {
>          ParseSingleInteger(false, Operands);
>        } else {
>          // Alignment not specified.
>          // FIXME: correctly derive a default from the instruction.
> -        // We can't just call WebAssembly::GetDefaultP2Align since we
> don't have
> -        // an opcode until after the assembly matcher.
>          Operands.push_back(make_unique<WebAssemblyOperand>(
> -                             WebAssemblyOperand::Integer, Offset.getLoc(),
> -                             Offset.getEndLoc(),
> WebAssemblyOperand::IntOp{0}));
> +                             WebAssemblyOperand::Integer, RParen.getLoc(),
> +                             RParen.getEndLoc(),
> WebAssemblyOperand::IntOp{0}));
>        }
>      }
>      return false;
> @@ -232,6 +360,11 @@ public:
>      while (Lexer.isNot(AsmToken::EndOfStatement)) {
>        auto &Tok = Lexer.getTok();
>        switch (Tok.getKind()) {
> +      case AsmToken::Dollar: {
> +        Parser.Lex();
> +        if (ParseReg(Operands, NamePair.first)) return true;
> +        break;
> +      }
>        case AsmToken::Identifier: {
>          auto &Id = Lexer.getTok();
>          const MCExpr *Val;
> @@ -247,11 +380,11 @@ public:
>          Parser.Lex();
>          if (Lexer.isNot(AsmToken::Integer))
>            return Error("Expected integer instead got: ", Lexer.getTok());
> -        if (ParseOperandStartingWithInteger(true, Operands,
> NamePair.second))
> +        if (ParseOperandStartingWithInteger(true, Operands,
> NamePair.first))
>            return true;
>          break;
>        case AsmToken::Integer:
> -        if (ParseOperandStartingWithInteger(false, Operands,
> NamePair.second))
> +        if (ParseOperandStartingWithInteger(false, Operands,
> NamePair.first))
>            return true;
>          break;
>        case AsmToken::Real: {
> @@ -272,6 +405,35 @@ public:
>        }
>      }
>      Parser.Lex();
> +    // Call instructions are vararg, but the tablegen matcher doesn't
> seem to
> +    // support that, so for now we strip these extra operands.
> +    // This is problematic if these arguments are not simple $pop stack
> +    // registers, since e.g. a local register would get lost, so we check
> for
> +    // this. This can be the case when using -disable-wasm-explicit-locals
> +    // which currently s2wasm requires.
> +    // TODO: Instead, we can move this code to MatchAndEmitInstruction
> below and
> +    // actually generate get_local instructions on the fly.
> +    // Or even better, improve the matcher to support vararg?
> +    auto IsIndirect = NamePair.second == "call_indirect";
> +    if (IsIndirect || NamePair.second == "call") {
> +      // Figure out number of fixed operands from the instruction.
> +      size_t CallOperands = 1;  // The name token.
> +      if (!IsIndirect) CallOperands++;  // The function index.
> +      if (!NamePair.first.empty()) CallOperands++;  // The result
> register.
> +      if (Operands.size() > CallOperands) {
> +        // Ensure operands we drop are all $pop.
> +        for (size_t I = CallOperands; I < Operands.size(); I++) {
> +          auto Operand =
> +              reinterpret_cast<WebAssemblyOperand *>(Operands[I].get());
> +          if (Operand->Kind != WebAssemblyOperand::Stack)
> +            Parser.Error(NameLoc,
> +              "Call instruction has non-stack arguments, if this code was
> "
> +              "generated with -disable-wasm-explicit-locals please remove
> it");
> +        }
> +        // Drop unneeded operands.
> +        Operands.resize(CallOperands);
> +      }
> +    }
>      // Block instructions require a signature index, but these are
> missing in
>      // assembly, so we add a dummy one explicitly (since we have no
> control
>      // over signature tables here, we assume these will be regenerated
> when
> @@ -281,6 +443,17 @@ public:
>                             WebAssemblyOperand::Integer, NameLoc,
>                             NameLoc, WebAssemblyOperand::IntOp{-1}));
>      }
> +    // These don't specify the type, which has to derived from the local
> index.
> +    if (NamePair.second == "get_local" || NamePair.second == "tee_local")
> {
> +      if (Operands.size() >= 3 && Operands[1]->isReg() &&
> +          Operands[2]->isImm()) {
> +        auto Op1 = reinterpret_cast<WebAssemblyOperand
> *>(Operands[1].get());
> +        auto Op2 = reinterpret_cast<WebAssemblyOperand
> *>(Operands[2].get());
> +        auto Type = GetType(LocalTypes,
> static_cast<size_t>(Op2->Int.Val));
> +        Op1->Reg.Type = Type;
> +        GetType(StackTypes, Op1->Reg.RegNo) = Type;
> +      }
> +    }
>      return false;
>    }
>
> @@ -304,6 +477,11 @@ public:
>              IsNext(AsmToken::At) &&
>              Lexer.is(AsmToken::Identifier)))
>          return Error("Expected label, at type declaration, got: ",
> Lexer.getTok());
> +      if (Lexer.getTok().getString() == "function") {
> +        // Track locals from start of function.
> +        LocalTypes.clear();
> +        StackTypes.clear();
> +      }
>        Parser.Lex();
>        //Out.EmitSymbolAttribute(??, MCSA_ELF_TypeFunction);
>      } else if (DirectiveID.getString() == ".param" ||
> @@ -316,6 +494,7 @@ public:
>        while (Lexer.is(AsmToken::Identifier)) {
>          auto RegType = ParseRegType(Lexer.getTok().getString());
>          if (RegType == MVT::INVALID_SIMPLE_VALUE_TYPE) return true;
> +        LocalTypes.push_back(RegType);
>          if (DirectiveID.getString() == ".param") {
>            Params.push_back(RegType);
>          } else {
>
> Modified: llvm/trunk/lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp?rev=339630&r1=339629&r2=339630&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp (original)
> +++ llvm/trunk/lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp Mon Aug 13
> 16:12:49 2018
> @@ -169,62 +169,45 @@ void WebAssemblyAsmPrinter::EmitInstruct
>
>    switch (MI->getOpcode()) {
>    case WebAssembly::ARGUMENT_I32:
> -  case WebAssembly::ARGUMENT_I32_S:
>    case WebAssembly::ARGUMENT_I64:
> -  case WebAssembly::ARGUMENT_I64_S:
>    case WebAssembly::ARGUMENT_F32:
> -  case WebAssembly::ARGUMENT_F32_S:
>    case WebAssembly::ARGUMENT_F64:
> -  case WebAssembly::ARGUMENT_F64_S:
>    case WebAssembly::ARGUMENT_v16i8:
> -  case WebAssembly::ARGUMENT_v16i8_S:
>    case WebAssembly::ARGUMENT_v8i16:
> -  case WebAssembly::ARGUMENT_v8i16_S:
>    case WebAssembly::ARGUMENT_v4i32:
> -  case WebAssembly::ARGUMENT_v4i32_S:
>    case WebAssembly::ARGUMENT_v2i64:
> -  case WebAssembly::ARGUMENT_v2i64_S:
>    case WebAssembly::ARGUMENT_v4f32:
> -  case WebAssembly::ARGUMENT_v4f32_S:
>    case WebAssembly::ARGUMENT_v2f64:
> -  case WebAssembly::ARGUMENT_v2f64_S:
>      // These represent values which are live into the function entry, so
> there's
>      // no instruction to emit.
>      break;
>    case WebAssembly::FALLTHROUGH_RETURN_I32:
> -  case WebAssembly::FALLTHROUGH_RETURN_I32_S:
>    case WebAssembly::FALLTHROUGH_RETURN_I64:
> -  case WebAssembly::FALLTHROUGH_RETURN_I64_S:
>    case WebAssembly::FALLTHROUGH_RETURN_F32:
> -  case WebAssembly::FALLTHROUGH_RETURN_F32_S:
>    case WebAssembly::FALLTHROUGH_RETURN_F64:
> -  case WebAssembly::FALLTHROUGH_RETURN_F64_S:
>    case WebAssembly::FALLTHROUGH_RETURN_v16i8:
> -  case WebAssembly::FALLTHROUGH_RETURN_v16i8_S:
>    case WebAssembly::FALLTHROUGH_RETURN_v8i16:
> -  case WebAssembly::FALLTHROUGH_RETURN_v8i16_S:
>    case WebAssembly::FALLTHROUGH_RETURN_v4i32:
> -  case WebAssembly::FALLTHROUGH_RETURN_v4i32_S:
>    case WebAssembly::FALLTHROUGH_RETURN_v2i64:
> -  case WebAssembly::FALLTHROUGH_RETURN_v2i64_S:
>    case WebAssembly::FALLTHROUGH_RETURN_v4f32:
> -  case WebAssembly::FALLTHROUGH_RETURN_v4f32_S:
> -  case WebAssembly::FALLTHROUGH_RETURN_v2f64:
> -  case WebAssembly::FALLTHROUGH_RETURN_v2f64_S: {
> +  case WebAssembly::FALLTHROUGH_RETURN_v2f64: {
>      // These instructions represent the implicit return at the end of a
> -    // function body. Always pops one value off the stack.
> +    // function body. The operand is always a pop.
> +    assert(MFI->isVRegStackified(MI->getOperand(0).getReg()));
> +
>      if (isVerbose()) {
> -      OutStreamer->AddComment("fallthrough-return-value");
> +      OutStreamer->AddComment("fallthrough-return: $pop" +
> +                              Twine(MFI->getWARegStackId(
> +
> MFI->getWAReg(MI->getOperand(0).getReg()))));
>        OutStreamer->AddBlankLine();
>      }
>      break;
>    }
>    case WebAssembly::FALLTHROUGH_RETURN_VOID:
> -  case WebAssembly::FALLTHROUGH_RETURN_VOID_S:
>      // This instruction represents the implicit return at the end of a
>      // function body with no return value.
>      if (isVerbose()) {
> -      OutStreamer->AddComment("fallthrough-return-void");
> +      OutStreamer->AddComment("fallthrough-return");
>        OutStreamer->AddBlankLine();
>      }
>      break;
> @@ -265,9 +248,6 @@ bool WebAssemblyAsmPrinter::PrintAsmOper
>        OS << MO.getImm();
>        return false;
>      case MachineOperand::MO_Register:
> -      // FIXME: only opcode that still contains registers, as required by
> -      // MachineInstr::getDebugVariable().
> -      assert(MI->getOpcode() == WebAssembly::INLINEASM);
>        OS << regToString(MO);
>        return false;
>      case MachineOperand::MO_GlobalAddress:
>
> Modified: llvm/trunk/lib/Target/WebAssembly/WebAssemblyExplicitLocals.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/WebAssembly/WebAssemblyExplicitLocals.cpp?rev=339630&r1=339629&r2=339630&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/Target/WebAssembly/WebAssemblyExplicitLocals.cpp
> (original)
> +++ llvm/trunk/lib/Target/WebAssembly/WebAssemblyExplicitLocals.cpp Mon
> Aug 13 16:12:49 2018
> @@ -31,21 +31,12 @@ using namespace llvm;
>
>  #define DEBUG_TYPE "wasm-explicit-locals"
>
> -// A command-line option to disable this pass, and keep implicit locals
> and
> -// stackified registers for the purpose of testing with lit/llc ONLY.
> -// This produces output which is not valid WebAssembly, and is not
> supported
> -// by assemblers/disassemblers and other MC based tools.
> -static cl::opt<bool> RegisterCodeGenTestMode(
> -    "wasm-register-codegen-test-mode", cl::Hidden,
> -    cl::desc("WebAssembly: output stack registers and implicit locals in"
> -             " instruction output for test purposes only."),
> -    cl::init(false));
> -// This one does explicit locals but keeps stackified registers, as
> required
> -// by some current tests.
> -static cl::opt<bool> ExplicitLocalsCodeGenTestMode(
> -    "wasm-explicit-locals-codegen-test-mode", cl::Hidden,
> -    cl::desc("WebAssembly: output stack registers and explicit locals in"
> -             " instruction output for test purposes only."),
> +// A command-line option to disable this pass. Note that this produces
> output
> +// which is not valid WebAssembly, though it may be more convenient for
> writing
> +// LLVM unit tests with.
> +static cl::opt<bool> DisableWebAssemblyExplicitLocals(
> +    "disable-wasm-explicit-locals", cl::ReallyHidden,
> +    cl::desc("WebAssembly: Disable emission of get_local/set_local."),
>      cl::init(false));
>
>  namespace {
> @@ -68,8 +59,6 @@ public:
>  };
>  } // end anonymous namespace
>
> -unsigned regInstructionToStackInstruction(unsigned OpCode);
> -
>  char WebAssemblyExplicitLocals::ID = 0;
>  INITIALIZE_PASS(WebAssemblyExplicitLocals, DEBUG_TYPE,
>                  "Convert registers to WebAssembly locals", false, false)
> @@ -173,7 +162,7 @@ static MVT typeForRegClass(const TargetR
>
>  /// Given a MachineOperand of a stackified vreg, return the instruction
> at the
>  /// start of the expression tree.
> -static MachineInstr *findStartOfTree(MachineOperand &MO,
> +static MachineInstr *FindStartOfTree(MachineOperand &MO,
>                                       MachineRegisterInfo &MRI,
>                                       WebAssemblyFunctionInfo &MFI) {
>    unsigned Reg = MO.getReg();
> @@ -184,7 +173,7 @@ static MachineInstr *findStartOfTree(Mac
>    for (MachineOperand &DefMO : Def->explicit_uses()) {
>      if (!DefMO.isReg())
>        continue;
> -    return findStartOfTree(DefMO, MRI, MFI);
> +    return FindStartOfTree(DefMO, MRI, MFI);
>    }
>
>    // If there were no stackified uses, we've reached the start.
> @@ -197,7 +186,7 @@ bool WebAssemblyExplicitLocals::runOnMac
>                      << MF.getName() << '\n');
>
>    // Disable this pass if directed to do so.
> -  if (RegisterCodeGenTestMode)
> +  if (DisableWebAssemblyExplicitLocals)
>      return false;
>
>    bool Changed = false;
> @@ -217,19 +206,19 @@ bool WebAssemblyExplicitLocals::runOnMac
>        break;
>      unsigned Reg = MI.getOperand(0).getReg();
>      assert(!MFI.isVRegStackified(Reg));
> -    Reg2Local[Reg] = static_cast<unsigned>(MI.getOperand(1).getImm());
> +    Reg2Local[Reg] = MI.getOperand(1).getImm();
>      MI.eraseFromParent();
>      Changed = true;
>    }
>
>    // Start assigning local numbers after the last parameter.
> -  unsigned CurLocal = static_cast<unsigned>(MFI.getParams().size());
> +  unsigned CurLocal = MFI.getParams().size();
>
>    // Precompute the set of registers that are unused, so that we can
> insert
>    // drops to their defs.
>    BitVector UseEmpty(MRI.getNumVirtRegs());
> -  for (unsigned I = 0, E = MRI.getNumVirtRegs(); I < E; ++I)
> -    UseEmpty[I] = MRI.use_empty(TargetRegisterInfo::index2VirtReg(I));
> +  for (unsigned i = 0, e = MRI.getNumVirtRegs(); i < e; ++i)
> +    UseEmpty[i] = MRI.use_empty(TargetRegisterInfo::index2VirtReg(i));
>
>    // Visit each instruction in the function.
>    for (MachineBasicBlock &MBB : MF) {
> @@ -333,7 +322,7 @@ bool WebAssemblyExplicitLocals::runOnMac
>          // If we see a stackified register, prepare to insert subsequent
>          // get_locals before the start of its tree.
>          if (MFI.isVRegStackified(OldReg)) {
> -          InsertPt = findStartOfTree(MO, MRI, MFI);
> +          InsertPt = FindStartOfTree(MO, MRI, MFI);
>            continue;
>          }
>
> @@ -367,414 +356,37 @@ bool WebAssemblyExplicitLocals::runOnMac
>          Changed = true;
>        }
>      }
> -
> -    if (!ExplicitLocalsCodeGenTestMode) {
> -      // Remove all uses of stackified registers to bring the instruction
> format
> -      // into its final stack form, and transition opcodes to their _S
> variant.
> -      // We do this in a seperate loop, since the previous loop
> adds/removes
> -      // instructions.
> -      // See comments in
> lib/Target/WebAssembly/WebAssemblyInstrFormats.td for
> -      // details.
> -      // TODO: the code above creates new registers which are then
> removed here.
> -      // That code could be slightly simplified by not doing that, though
> maybe
> -      // it is simpler conceptually to keep the code above in "register
> mode"
> -      // until this transition point.
> -      for (MachineBasicBlock::iterator I = MBB.begin(), E = MBB.end();
> -           I != E;) {
> -        MachineInstr &MI = *I++;
> -        // FIXME: we are not processing inline assembly, which contains
> register
> -        // operands, because it is used by later target generic code.
> -        if (MI.isDebugInstr() || MI.isLabel() || MI.isInlineAsm())
> -          continue;
> -        auto RegOpcode = MI.getOpcode();
> -        auto StackOpcode = regInstructionToStackInstruction(RegOpcode);
> -        MI.setDesc(TII->get(StackOpcode));
> -        // Now remove all register operands.
> -        for (auto I = MI.getNumOperands(); I; --I) {
> -          auto &MO = MI.getOperand(I - 1);
> -          if (MO.isReg()) {
> -            MI.RemoveOperand(I - 1);
> -            // TODO: we should also update the MFI here or below to
> reflect the
> -            // removed registers? The MFI is about to be deleted anyway,
> so
> -            // maybe that is not worth it?
> -          }
> -        }
> -      }
> -    }
>    }
>
>    // Define the locals.
>    // TODO: Sort the locals for better compression.
>    MFI.setNumLocals(CurLocal - MFI.getParams().size());
> -  for (unsigned I = 0, E = MRI.getNumVirtRegs(); I < E; ++I) {
> -    unsigned Reg = TargetRegisterInfo::index2VirtReg(I);
> -    auto RL = Reg2Local.find(Reg);
> -    if (RL == Reg2Local.end() || RL->second < MFI.getParams().size())
> +  for (size_t i = 0, e = MRI.getNumVirtRegs(); i < e; ++i) {
> +    unsigned Reg = TargetRegisterInfo::index2VirtReg(i);
> +    auto I = Reg2Local.find(Reg);
> +    if (I == Reg2Local.end() || I->second < MFI.getParams().size())
>        continue;
>
> -    MFI.setLocal(RL->second - MFI.getParams().size(),
> +    MFI.setLocal(I->second - MFI.getParams().size(),
>                   typeForRegClass(MRI.getRegClass(Reg)));
>      Changed = true;
>    }
>
> -  return Changed;
> -}
> -
> -unsigned regInstructionToStackInstruction(unsigned OpCode) {
> -  switch (OpCode) {
> -  default:
> -    // You may hit this if you add new instructions, please add them
> below.
> -    // For most of these opcodes, this function could have been
> implemented
> -    // as "return OpCode + 1", but since table-gen alphabetically sorts
> them,
> -    // this cannot be guaranteed (see e.g. BR and BR_IF).
> -    // The approach below is the same as what the x87 backend does.
> -    // TODO(wvo): to make this code cleaner, create a custom tablegen
> -    // code generator that emits the table below automatically.
> -    llvm_unreachable(
> -          "unknown WebAssembly instruction in Explicit Locals pass");
> -  case WebAssembly::ABS_F32: return WebAssembly::ABS_F32_S;
> -  case WebAssembly::ABS_F64: return WebAssembly::ABS_F64_S;
> -  case WebAssembly::ADD_F32: return WebAssembly::ADD_F32_S;
> -  case WebAssembly::ADD_F32x4: return WebAssembly::ADD_F32x4_S;
> -  case WebAssembly::ADD_F64: return WebAssembly::ADD_F64_S;
> -  case WebAssembly::ADD_I16x8: return WebAssembly::ADD_I16x8_S;
> -  case WebAssembly::ADD_I32: return WebAssembly::ADD_I32_S;
> -  case WebAssembly::ADD_I32x4: return WebAssembly::ADD_I32x4_S;
> -  case WebAssembly::ADD_I64: return WebAssembly::ADD_I64_S;
> -  case WebAssembly::ADD_I8x16: return WebAssembly::ADD_I8x16_S;
> -  case WebAssembly::ADJCALLSTACKDOWN: return
> WebAssembly::ADJCALLSTACKDOWN_S;
> -  case WebAssembly::ADJCALLSTACKUP: return WebAssembly::ADJCALLSTACKUP_S;
> -  case WebAssembly::AND_I32: return WebAssembly::AND_I32_S;
> -  case WebAssembly::AND_I64: return WebAssembly::AND_I64_S;
> -  case WebAssembly::ARGUMENT_EXCEPT_REF: return
> WebAssembly::ARGUMENT_EXCEPT_REF_S;
> -  case WebAssembly::ARGUMENT_F32: return WebAssembly::ARGUMENT_F32_S;
> -  case WebAssembly::ARGUMENT_F64: return WebAssembly::ARGUMENT_F64_S;
> -  case WebAssembly::ARGUMENT_I32: return WebAssembly::ARGUMENT_I32_S;
> -  case WebAssembly::ARGUMENT_I64: return WebAssembly::ARGUMENT_I64_S;
> -  case WebAssembly::ARGUMENT_v16i8: return WebAssembly::ARGUMENT_v16i8_S;
> -  case WebAssembly::ARGUMENT_v4f32: return WebAssembly::ARGUMENT_v4f32_S;
> -  case WebAssembly::ARGUMENT_v4i32: return WebAssembly::ARGUMENT_v4i32_S;
> -  case WebAssembly::ARGUMENT_v8i16: return WebAssembly::ARGUMENT_v8i16_S;
> -  case WebAssembly::ARGUMENT_v2f64: return WebAssembly::ARGUMENT_v2f64_S;
> -  case WebAssembly::ARGUMENT_v2i64: return WebAssembly::ARGUMENT_v2i64_S;
> -  case WebAssembly::ATOMIC_LOAD16_U_I32: return
> WebAssembly::ATOMIC_LOAD16_U_I32_S;
> -  case WebAssembly::ATOMIC_LOAD16_U_I64: return
> WebAssembly::ATOMIC_LOAD16_U_I64_S;
> -  case WebAssembly::ATOMIC_LOAD32_U_I64: return
> WebAssembly::ATOMIC_LOAD32_U_I64_S;
> -  case WebAssembly::ATOMIC_LOAD8_U_I32: return
> WebAssembly::ATOMIC_LOAD8_U_I32_S;
> -  case WebAssembly::ATOMIC_LOAD8_U_I64: return
> WebAssembly::ATOMIC_LOAD8_U_I64_S;
> -  case WebAssembly::ATOMIC_LOAD_I32: return
> WebAssembly::ATOMIC_LOAD_I32_S;
> -  case WebAssembly::ATOMIC_LOAD_I64: return
> WebAssembly::ATOMIC_LOAD_I64_S;
> -  case WebAssembly::ATOMIC_STORE16_I32: return
> WebAssembly::ATOMIC_STORE16_I32_S;
> -  case WebAssembly::ATOMIC_STORE16_I64: return
> WebAssembly::ATOMIC_STORE16_I64_S;
> -  case WebAssembly::ATOMIC_STORE32_I64: return
> WebAssembly::ATOMIC_STORE32_I64_S;
> -  case WebAssembly::ATOMIC_STORE8_I32: return
> WebAssembly::ATOMIC_STORE8_I32_S;
> -  case WebAssembly::ATOMIC_STORE8_I64: return
> WebAssembly::ATOMIC_STORE8_I64_S;
> -  case WebAssembly::ATOMIC_STORE_I32: return
> WebAssembly::ATOMIC_STORE_I32_S;
> -  case WebAssembly::ATOMIC_STORE_I64: return
> WebAssembly::ATOMIC_STORE_I64_S;
> -  case WebAssembly::BLOCK: return WebAssembly::BLOCK_S;
> -  case WebAssembly::BR: return WebAssembly::BR_S;
> -  case WebAssembly::BR_IF: return WebAssembly::BR_IF_S;
> -  case WebAssembly::BR_TABLE_I32: return WebAssembly::BR_TABLE_I32_S;
> -  case WebAssembly::BR_TABLE_I64: return WebAssembly::BR_TABLE_I64_S;
> -  case WebAssembly::BR_UNLESS: return WebAssembly::BR_UNLESS_S;
> -  case WebAssembly::CALL_EXCEPT_REF: return
> WebAssembly::CALL_EXCEPT_REF_S;
> -  case WebAssembly::CALL_F32: return WebAssembly::CALL_F32_S;
> -  case WebAssembly::CALL_F64: return WebAssembly::CALL_F64_S;
> -  case WebAssembly::CALL_I32: return WebAssembly::CALL_I32_S;
> -  case WebAssembly::CALL_I64: return WebAssembly::CALL_I64_S;
> -  case WebAssembly::CALL_INDIRECT_EXCEPT_REF: return
> WebAssembly::CALL_INDIRECT_EXCEPT_REF_S;
> -  case WebAssembly::CALL_INDIRECT_F32: return
> WebAssembly::CALL_INDIRECT_F32_S;
> -  case WebAssembly::CALL_INDIRECT_F64: return
> WebAssembly::CALL_INDIRECT_F64_S;
> -  case WebAssembly::CALL_INDIRECT_I32: return
> WebAssembly::CALL_INDIRECT_I32_S;
> -  case WebAssembly::CALL_INDIRECT_I64: return
> WebAssembly::CALL_INDIRECT_I64_S;
> -  case WebAssembly::CALL_INDIRECT_VOID: return
> WebAssembly::CALL_INDIRECT_VOID_S;
> -  case WebAssembly::CALL_INDIRECT_v16i8: return
> WebAssembly::CALL_INDIRECT_v16i8_S;
> -  case WebAssembly::CALL_INDIRECT_v4f32: return
> WebAssembly::CALL_INDIRECT_v4f32_S;
> -  case WebAssembly::CALL_INDIRECT_v4i32: return
> WebAssembly::CALL_INDIRECT_v4i32_S;
> -  case WebAssembly::CALL_INDIRECT_v8i16: return
> WebAssembly::CALL_INDIRECT_v8i16_S;
> -  case WebAssembly::CALL_VOID: return WebAssembly::CALL_VOID_S;
> -  case WebAssembly::CALL_v16i8: return WebAssembly::CALL_v16i8_S;
> -  case WebAssembly::CALL_v4f32: return WebAssembly::CALL_v4f32_S;
> -  case WebAssembly::CALL_v4i32: return WebAssembly::CALL_v4i32_S;
> -  case WebAssembly::CALL_v8i16: return WebAssembly::CALL_v8i16_S;
> -  case WebAssembly::CATCHRET: return WebAssembly::CATCHRET_S;
> -  case WebAssembly::CATCH_ALL: return WebAssembly::CATCH_ALL_S;
> -  case WebAssembly::CATCH_I32: return WebAssembly::CATCH_I32_S;
> -  case WebAssembly::CATCH_I64: return WebAssembly::CATCH_I64_S;
> -  case WebAssembly::CEIL_F32: return WebAssembly::CEIL_F32_S;
> -  case WebAssembly::CEIL_F64: return WebAssembly::CEIL_F64_S;
> -  case WebAssembly::CLEANUPRET: return WebAssembly::CLEANUPRET_S;
> -  case WebAssembly::CLZ_I32: return WebAssembly::CLZ_I32_S;
> -  case WebAssembly::CLZ_I64: return WebAssembly::CLZ_I64_S;
> -  case WebAssembly::CONST_F32: return WebAssembly::CONST_F32_S;
> -  case WebAssembly::CONST_F64: return WebAssembly::CONST_F64_S;
> -  case WebAssembly::CONST_I32: return WebAssembly::CONST_I32_S;
> -  case WebAssembly::CONST_I64: return WebAssembly::CONST_I64_S;
> -  case WebAssembly::COPYSIGN_F32: return WebAssembly::COPYSIGN_F32_S;
> -  case WebAssembly::COPYSIGN_F64: return WebAssembly::COPYSIGN_F64_S;
> -  case WebAssembly::COPY_EXCEPT_REF: return
> WebAssembly::COPY_EXCEPT_REF_S;
> -  case WebAssembly::COPY_F32: return WebAssembly::COPY_F32_S;
> -  case WebAssembly::COPY_F64: return WebAssembly::COPY_F64_S;
> -  case WebAssembly::COPY_I32: return WebAssembly::COPY_I32_S;
> -  case WebAssembly::COPY_I64: return WebAssembly::COPY_I64_S;
> -  case WebAssembly::COPY_V128: return WebAssembly::COPY_V128_S;
> -  case WebAssembly::CTZ_I32: return WebAssembly::CTZ_I32_S;
> -  case WebAssembly::CTZ_I64: return WebAssembly::CTZ_I64_S;
> -  case WebAssembly::CURRENT_MEMORY_I32: return
> WebAssembly::CURRENT_MEMORY_I32_S;
> -  case WebAssembly::DIV_F32: return WebAssembly::DIV_F32_S;
> -  case WebAssembly::DIV_F64: return WebAssembly::DIV_F64_S;
> -  case WebAssembly::DIV_S_I32: return WebAssembly::DIV_S_I32_S;
> -  case WebAssembly::DIV_S_I64: return WebAssembly::DIV_S_I64_S;
> -  case WebAssembly::DIV_U_I32: return WebAssembly::DIV_U_I32_S;
> -  case WebAssembly::DIV_U_I64: return WebAssembly::DIV_U_I64_S;
> -  case WebAssembly::DROP_EXCEPT_REF: return
> WebAssembly::DROP_EXCEPT_REF_S;
> -  case WebAssembly::DROP_F32: return WebAssembly::DROP_F32_S;
> -  case WebAssembly::DROP_F64: return WebAssembly::DROP_F64_S;
> -  case WebAssembly::DROP_I32: return WebAssembly::DROP_I32_S;
> -  case WebAssembly::DROP_I64: return WebAssembly::DROP_I64_S;
> -  case WebAssembly::DROP_V128: return WebAssembly::DROP_V128_S;
> -  case WebAssembly::END_BLOCK: return WebAssembly::END_BLOCK_S;
> -  case WebAssembly::END_FUNCTION: return WebAssembly::END_FUNCTION_S;
> -  case WebAssembly::END_LOOP: return WebAssembly::END_LOOP_S;
> -  case WebAssembly::END_TRY: return WebAssembly::END_TRY_S;
> -  case WebAssembly::EQZ_I32: return WebAssembly::EQZ_I32_S;
> -  case WebAssembly::EQZ_I64: return WebAssembly::EQZ_I64_S;
> -  case WebAssembly::EQ_F32: return WebAssembly::EQ_F32_S;
> -  case WebAssembly::EQ_F64: return WebAssembly::EQ_F64_S;
> -  case WebAssembly::EQ_I32: return WebAssembly::EQ_I32_S;
> -  case WebAssembly::EQ_I64: return WebAssembly::EQ_I64_S;
> -  case WebAssembly::F32_CONVERT_S_I32: return
> WebAssembly::F32_CONVERT_S_I32_S;
> -  case WebAssembly::F32_CONVERT_S_I64: return
> WebAssembly::F32_CONVERT_S_I64_S;
> -  case WebAssembly::F32_CONVERT_U_I32: return
> WebAssembly::F32_CONVERT_U_I32_S;
> -  case WebAssembly::F32_CONVERT_U_I64: return
> WebAssembly::F32_CONVERT_U_I64_S;
> -  case WebAssembly::F32_DEMOTE_F64: return WebAssembly::F32_DEMOTE_F64_S;
> -  case WebAssembly::F32_REINTERPRET_I32: return
> WebAssembly::F32_REINTERPRET_I32_S;
> -  case WebAssembly::F64_CONVERT_S_I32: return
> WebAssembly::F64_CONVERT_S_I32_S;
> -  case WebAssembly::F64_CONVERT_S_I64: return
> WebAssembly::F64_CONVERT_S_I64_S;
> -  case WebAssembly::F64_CONVERT_U_I32: return
> WebAssembly::F64_CONVERT_U_I32_S;
> -  case WebAssembly::F64_CONVERT_U_I64: return
> WebAssembly::F64_CONVERT_U_I64_S;
> -  case WebAssembly::F64_PROMOTE_F32: return
> WebAssembly::F64_PROMOTE_F32_S;
> -  case WebAssembly::F64_REINTERPRET_I64: return
> WebAssembly::F64_REINTERPRET_I64_S;
> -  case WebAssembly::FALLTHROUGH_RETURN_EXCEPT_REF: return
> WebAssembly::FALLTHROUGH_RETURN_EXCEPT_REF_S;
> -  case WebAssembly::FALLTHROUGH_RETURN_F32: return
> WebAssembly::FALLTHROUGH_RETURN_F32_S;
> -  case WebAssembly::FALLTHROUGH_RETURN_F64: return
> WebAssembly::FALLTHROUGH_RETURN_F64_S;
> -  case WebAssembly::FALLTHROUGH_RETURN_I32: return
> WebAssembly::FALLTHROUGH_RETURN_I32_S;
> -  case WebAssembly::FALLTHROUGH_RETURN_I64: return
> WebAssembly::FALLTHROUGH_RETURN_I64_S;
> -  case WebAssembly::FALLTHROUGH_RETURN_VOID: return
> WebAssembly::FALLTHROUGH_RETURN_VOID_S;
> -  case WebAssembly::FALLTHROUGH_RETURN_v16i8: return
> WebAssembly::FALLTHROUGH_RETURN_v16i8_S;
> -  case WebAssembly::FALLTHROUGH_RETURN_v4f32: return
> WebAssembly::FALLTHROUGH_RETURN_v4f32_S;
> -  case WebAssembly::FALLTHROUGH_RETURN_v4i32: return
> WebAssembly::FALLTHROUGH_RETURN_v4i32_S;
> -  case WebAssembly::FALLTHROUGH_RETURN_v8i16: return
> WebAssembly::FALLTHROUGH_RETURN_v8i16_S;
> -  case WebAssembly::FALLTHROUGH_RETURN_v2f64: return
> WebAssembly::FALLTHROUGH_RETURN_v2f64_S;
> -  case WebAssembly::FALLTHROUGH_RETURN_v2i64: return
> WebAssembly::FALLTHROUGH_RETURN_v2i64_S;
> -  case WebAssembly::FLOOR_F32: return WebAssembly::FLOOR_F32_S;
> -  case WebAssembly::FLOOR_F64: return WebAssembly::FLOOR_F64_S;
> -  case WebAssembly::FP_TO_SINT_I32_F32: return
> WebAssembly::FP_TO_SINT_I32_F32_S;
> -  case WebAssembly::FP_TO_SINT_I32_F64: return
> WebAssembly::FP_TO_SINT_I32_F64_S;
> -  case WebAssembly::FP_TO_SINT_I64_F32: return
> WebAssembly::FP_TO_SINT_I64_F32_S;
> -  case WebAssembly::FP_TO_SINT_I64_F64: return
> WebAssembly::FP_TO_SINT_I64_F64_S;
> -  case WebAssembly::FP_TO_UINT_I32_F32: return
> WebAssembly::FP_TO_UINT_I32_F32_S;
> -  case WebAssembly::FP_TO_UINT_I32_F64: return
> WebAssembly::FP_TO_UINT_I32_F64_S;
> -  case WebAssembly::FP_TO_UINT_I64_F32: return
> WebAssembly::FP_TO_UINT_I64_F32_S;
> -  case WebAssembly::FP_TO_UINT_I64_F64: return
> WebAssembly::FP_TO_UINT_I64_F64_S;
> -  case WebAssembly::GET_GLOBAL_EXCEPT_REF: return
> WebAssembly::GET_GLOBAL_EXCEPT_REF_S;
> -  case WebAssembly::GET_GLOBAL_F32: return WebAssembly::GET_GLOBAL_F32_S;
> -  case WebAssembly::GET_GLOBAL_F64: return WebAssembly::GET_GLOBAL_F64_S;
> -  case WebAssembly::GET_GLOBAL_I32: return WebAssembly::GET_GLOBAL_I32_S;
> -  case WebAssembly::GET_GLOBAL_I64: return WebAssembly::GET_GLOBAL_I64_S;
> -  case WebAssembly::GET_GLOBAL_V128: return
> WebAssembly::GET_GLOBAL_V128_S;
> -  case WebAssembly::GET_LOCAL_EXCEPT_REF: return
> WebAssembly::GET_LOCAL_EXCEPT_REF_S;
> -  case WebAssembly::GET_LOCAL_F32: return WebAssembly::GET_LOCAL_F32_S;
> -  case WebAssembly::GET_LOCAL_F64: return WebAssembly::GET_LOCAL_F64_S;
> -  case WebAssembly::GET_LOCAL_I32: return WebAssembly::GET_LOCAL_I32_S;
> -  case WebAssembly::GET_LOCAL_I64: return WebAssembly::GET_LOCAL_I64_S;
> -  case WebAssembly::GET_LOCAL_V128: return WebAssembly::GET_LOCAL_V128_S;
> -  case WebAssembly::GE_F32: return WebAssembly::GE_F32_S;
> -  case WebAssembly::GE_F64: return WebAssembly::GE_F64_S;
> -  case WebAssembly::GE_S_I32: return WebAssembly::GE_S_I32_S;
> -  case WebAssembly::GE_S_I64: return WebAssembly::GE_S_I64_S;
> -  case WebAssembly::GE_U_I32: return WebAssembly::GE_U_I32_S;
> -  case WebAssembly::GE_U_I64: return WebAssembly::GE_U_I64_S;
> -  case WebAssembly::GROW_MEMORY_I32: return
> WebAssembly::GROW_MEMORY_I32_S;
> -  case WebAssembly::GT_F32: return WebAssembly::GT_F32_S;
> -  case WebAssembly::GT_F64: return WebAssembly::GT_F64_S;
> -  case WebAssembly::GT_S_I32: return WebAssembly::GT_S_I32_S;
> -  case WebAssembly::GT_S_I64: return WebAssembly::GT_S_I64_S;
> -  case WebAssembly::GT_U_I32: return WebAssembly::GT_U_I32_S;
> -  case WebAssembly::GT_U_I64: return WebAssembly::GT_U_I64_S;
> -  case WebAssembly::I32_EXTEND16_S_I32: return
> WebAssembly::I32_EXTEND16_S_I32_S;
> -  case WebAssembly::I32_EXTEND8_S_I32: return
> WebAssembly::I32_EXTEND8_S_I32_S;
> -  case WebAssembly::I32_REINTERPRET_F32: return
> WebAssembly::I32_REINTERPRET_F32_S;
> -  case WebAssembly::I32_TRUNC_S_F32: return
> WebAssembly::I32_TRUNC_S_F32_S;
> -  case WebAssembly::I32_TRUNC_S_F64: return
> WebAssembly::I32_TRUNC_S_F64_S;
> -  case WebAssembly::I32_TRUNC_S_SAT_F32: return
> WebAssembly::I32_TRUNC_S_SAT_F32_S;
> -  case WebAssembly::I32_TRUNC_S_SAT_F64: return
> WebAssembly::I32_TRUNC_S_SAT_F64_S;
> -  case WebAssembly::I32_TRUNC_U_F32: return
> WebAssembly::I32_TRUNC_U_F32_S;
> -  case WebAssembly::I32_TRUNC_U_F64: return
> WebAssembly::I32_TRUNC_U_F64_S;
> -  case WebAssembly::I32_TRUNC_U_SAT_F32: return
> WebAssembly::I32_TRUNC_U_SAT_F32_S;
> -  case WebAssembly::I32_TRUNC_U_SAT_F64: return
> WebAssembly::I32_TRUNC_U_SAT_F64_S;
> -  case WebAssembly::I32_WRAP_I64: return WebAssembly::I32_WRAP_I64_S;
> -  case WebAssembly::I64_EXTEND16_S_I64: return
> WebAssembly::I64_EXTEND16_S_I64_S;
> -  case WebAssembly::I64_EXTEND32_S_I64: return
> WebAssembly::I64_EXTEND32_S_I64_S;
> -  case WebAssembly::I64_EXTEND8_S_I64: return
> WebAssembly::I64_EXTEND8_S_I64_S;
> -  case WebAssembly::I64_EXTEND_S_I32: return
> WebAssembly::I64_EXTEND_S_I32_S;
> -  case WebAssembly::I64_EXTEND_U_I32: return
> WebAssembly::I64_EXTEND_U_I32_S;
> -  case WebAssembly::I64_REINTERPRET_F64: return
> WebAssembly::I64_REINTERPRET_F64_S;
> -  case WebAssembly::I64_TRUNC_S_F32: return
> WebAssembly::I64_TRUNC_S_F32_S;
> -  case WebAssembly::I64_TRUNC_S_F64: return
> WebAssembly::I64_TRUNC_S_F64_S;
> -  case WebAssembly::I64_TRUNC_S_SAT_F32: return
> WebAssembly::I64_TRUNC_S_SAT_F32_S;
> -  case WebAssembly::I64_TRUNC_S_SAT_F64: return
> WebAssembly::I64_TRUNC_S_SAT_F64_S;
> -  case WebAssembly::I64_TRUNC_U_F32: return
> WebAssembly::I64_TRUNC_U_F32_S;
> -  case WebAssembly::I64_TRUNC_U_F64: return
> WebAssembly::I64_TRUNC_U_F64_S;
> -  case WebAssembly::I64_TRUNC_U_SAT_F32: return
> WebAssembly::I64_TRUNC_U_SAT_F32_S;
> -  case WebAssembly::I64_TRUNC_U_SAT_F64: return
> WebAssembly::I64_TRUNC_U_SAT_F64_S;
> -  case WebAssembly::LE_F32: return WebAssembly::LE_F32_S;
> -  case WebAssembly::LE_F64: return WebAssembly::LE_F64_S;
> -  case WebAssembly::LE_S_I32: return WebAssembly::LE_S_I32_S;
> -  case WebAssembly::LE_S_I64: return WebAssembly::LE_S_I64_S;
> -  case WebAssembly::LE_U_I32: return WebAssembly::LE_U_I32_S;
> -  case WebAssembly::LE_U_I64: return WebAssembly::LE_U_I64_S;
> -  case WebAssembly::LOAD16_S_I32: return WebAssembly::LOAD16_S_I32_S;
> -  case WebAssembly::LOAD16_S_I64: return WebAssembly::LOAD16_S_I64_S;
> -  case WebAssembly::LOAD16_U_I32: return WebAssembly::LOAD16_U_I32_S;
> -  case WebAssembly::LOAD16_U_I64: return WebAssembly::LOAD16_U_I64_S;
> -  case WebAssembly::LOAD32_S_I64: return WebAssembly::LOAD32_S_I64_S;
> -  case WebAssembly::LOAD32_U_I64: return WebAssembly::LOAD32_U_I64_S;
> -  case WebAssembly::LOAD8_S_I32: return WebAssembly::LOAD8_S_I32_S;
> -  case WebAssembly::LOAD8_S_I64: return WebAssembly::LOAD8_S_I64_S;
> -  case WebAssembly::LOAD8_U_I32: return WebAssembly::LOAD8_U_I32_S;
> -  case WebAssembly::LOAD8_U_I64: return WebAssembly::LOAD8_U_I64_S;
> -  case WebAssembly::LOAD_F32: return WebAssembly::LOAD_F32_S;
> -  case WebAssembly::LOAD_F64: return WebAssembly::LOAD_F64_S;
> -  case WebAssembly::LOAD_I32: return WebAssembly::LOAD_I32_S;
> -  case WebAssembly::LOAD_I64: return WebAssembly::LOAD_I64_S;
> -  case WebAssembly::LOOP: return WebAssembly::LOOP_S;
> -  case WebAssembly::LT_F32: return WebAssembly::LT_F32_S;
> -  case WebAssembly::LT_F64: return WebAssembly::LT_F64_S;
> -  case WebAssembly::LT_S_I32: return WebAssembly::LT_S_I32_S;
> -  case WebAssembly::LT_S_I64: return WebAssembly::LT_S_I64_S;
> -  case WebAssembly::LT_U_I32: return WebAssembly::LT_U_I32_S;
> -  case WebAssembly::LT_U_I64: return WebAssembly::LT_U_I64_S;
> -  case WebAssembly::MAX_F32: return WebAssembly::MAX_F32_S;
> -  case WebAssembly::MAX_F64: return WebAssembly::MAX_F64_S;
> -  case WebAssembly::MEMORY_GROW_I32: return
> WebAssembly::MEMORY_GROW_I32_S;
> -  case WebAssembly::MEMORY_SIZE_I32: return
> WebAssembly::MEMORY_SIZE_I32_S;
> -  case WebAssembly::MEM_GROW_I32: return WebAssembly::MEM_GROW_I32_S;
> -  case WebAssembly::MEM_SIZE_I32: return WebAssembly::MEM_SIZE_I32_S;
> -  case WebAssembly::MIN_F32: return WebAssembly::MIN_F32_S;
> -  case WebAssembly::MIN_F64: return WebAssembly::MIN_F64_S;
> -  case WebAssembly::MUL_F32: return WebAssembly::MUL_F32_S;
> -  case WebAssembly::MUL_F32x4: return WebAssembly::MUL_F32x4_S;
> -  case WebAssembly::MUL_F64: return WebAssembly::MUL_F64_S;
> -  case WebAssembly::MUL_I16x8: return WebAssembly::MUL_I16x8_S;
> -  case WebAssembly::MUL_I32: return WebAssembly::MUL_I32_S;
> -  case WebAssembly::MUL_I32x4: return WebAssembly::MUL_I32x4_S;
> -  case WebAssembly::MUL_I64: return WebAssembly::MUL_I64_S;
> -  case WebAssembly::MUL_I8x16: return WebAssembly::MUL_I8x16_S;
> -  case WebAssembly::NEAREST_F32: return WebAssembly::NEAREST_F32_S;
> -  case WebAssembly::NEAREST_F64: return WebAssembly::NEAREST_F64_S;
> -  case WebAssembly::NEG_F32: return WebAssembly::NEG_F32_S;
> -  case WebAssembly::NEG_F64: return WebAssembly::NEG_F64_S;
> -  case WebAssembly::NE_F32: return WebAssembly::NE_F32_S;
> -  case WebAssembly::NE_F64: return WebAssembly::NE_F64_S;
> -  case WebAssembly::NE_I32: return WebAssembly::NE_I32_S;
> -  case WebAssembly::NE_I64: return WebAssembly::NE_I64_S;
> -  case WebAssembly::NOP: return WebAssembly::NOP_S;
> -  case WebAssembly::OR_I32: return WebAssembly::OR_I32_S;
> -  case WebAssembly::OR_I64: return WebAssembly::OR_I64_S;
> -  case WebAssembly::PCALL_INDIRECT_EXCEPT_REF: return
> WebAssembly::PCALL_INDIRECT_EXCEPT_REF_S;
> -  case WebAssembly::PCALL_INDIRECT_F32: return
> WebAssembly::PCALL_INDIRECT_F32_S;
> -  case WebAssembly::PCALL_INDIRECT_F64: return
> WebAssembly::PCALL_INDIRECT_F64_S;
> -  case WebAssembly::PCALL_INDIRECT_I32: return
> WebAssembly::PCALL_INDIRECT_I32_S;
> -  case WebAssembly::PCALL_INDIRECT_I64: return
> WebAssembly::PCALL_INDIRECT_I64_S;
> -  case WebAssembly::PCALL_INDIRECT_VOID: return
> WebAssembly::PCALL_INDIRECT_VOID_S;
> -  case WebAssembly::PCALL_INDIRECT_v16i8: return
> WebAssembly::PCALL_INDIRECT_v16i8_S;
> -  case WebAssembly::PCALL_INDIRECT_v4f32: return
> WebAssembly::PCALL_INDIRECT_v4f32_S;
> -  case WebAssembly::PCALL_INDIRECT_v4i32: return
> WebAssembly::PCALL_INDIRECT_v4i32_S;
> -  case WebAssembly::PCALL_INDIRECT_v8i16: return
> WebAssembly::PCALL_INDIRECT_v8i16_S;
> -  case WebAssembly::POPCNT_I32: return WebAssembly::POPCNT_I32_S;
> -  case WebAssembly::POPCNT_I64: return WebAssembly::POPCNT_I64_S;
> -  case WebAssembly::REM_S_I32: return WebAssembly::REM_S_I32_S;
> -  case WebAssembly::REM_S_I64: return WebAssembly::REM_S_I64_S;
> -  case WebAssembly::REM_U_I32: return WebAssembly::REM_U_I32_S;
> -  case WebAssembly::REM_U_I64: return WebAssembly::REM_U_I64_S;
> -  case WebAssembly::RETHROW: return WebAssembly::RETHROW_S;
> -  case WebAssembly::RETHROW_TO_CALLER: return
> WebAssembly::RETHROW_TO_CALLER_S;
> -  case WebAssembly::RETURN_EXCEPT_REF: return
> WebAssembly::RETURN_EXCEPT_REF_S;
> -  case WebAssembly::RETURN_F32: return WebAssembly::RETURN_F32_S;
> -  case WebAssembly::RETURN_F64: return WebAssembly::RETURN_F64_S;
> -  case WebAssembly::RETURN_I32: return WebAssembly::RETURN_I32_S;
> -  case WebAssembly::RETURN_I64: return WebAssembly::RETURN_I64_S;
> -  case WebAssembly::RETURN_VOID: return WebAssembly::RETURN_VOID_S;
> -  case WebAssembly::RETURN_v16i8: return WebAssembly::RETURN_v16i8_S;
> -  case WebAssembly::RETURN_v4f32: return WebAssembly::RETURN_v4f32_S;
> -  case WebAssembly::RETURN_v4i32: return WebAssembly::RETURN_v4i32_S;
> -  case WebAssembly::RETURN_v8i16: return WebAssembly::RETURN_v8i16_S;
> -  case WebAssembly::ROTL_I32: return WebAssembly::ROTL_I32_S;
> -  case WebAssembly::ROTL_I64: return WebAssembly::ROTL_I64_S;
> -  case WebAssembly::ROTR_I32: return WebAssembly::ROTR_I32_S;
> -  case WebAssembly::ROTR_I64: return WebAssembly::ROTR_I64_S;
> -  case WebAssembly::SELECT_EXCEPT_REF: return
> WebAssembly::SELECT_EXCEPT_REF_S;
> -  case WebAssembly::SELECT_F32: return WebAssembly::SELECT_F32_S;
> -  case WebAssembly::SELECT_F64: return WebAssembly::SELECT_F64_S;
> -  case WebAssembly::SELECT_I32: return WebAssembly::SELECT_I32_S;
> -  case WebAssembly::SELECT_I64: return WebAssembly::SELECT_I64_S;
> -  case WebAssembly::SET_GLOBAL_EXCEPT_REF: return
> WebAssembly::SET_GLOBAL_EXCEPT_REF_S;
> -  case WebAssembly::SET_GLOBAL_F32: return WebAssembly::SET_GLOBAL_F32_S;
> -  case WebAssembly::SET_GLOBAL_F64: return WebAssembly::SET_GLOBAL_F64_S;
> -  case WebAssembly::SET_GLOBAL_I32: return WebAssembly::SET_GLOBAL_I32_S;
> -  case WebAssembly::SET_GLOBAL_I64: return WebAssembly::SET_GLOBAL_I64_S;
> -  case WebAssembly::SET_GLOBAL_V128: return
> WebAssembly::SET_GLOBAL_V128_S;
> -  case WebAssembly::SET_LOCAL_EXCEPT_REF: return
> WebAssembly::SET_LOCAL_EXCEPT_REF_S;
> -  case WebAssembly::SET_LOCAL_F32: return WebAssembly::SET_LOCAL_F32_S;
> -  case WebAssembly::SET_LOCAL_F64: return WebAssembly::SET_LOCAL_F64_S;
> -  case WebAssembly::SET_LOCAL_I32: return WebAssembly::SET_LOCAL_I32_S;
> -  case WebAssembly::SET_LOCAL_I64: return WebAssembly::SET_LOCAL_I64_S;
> -  case WebAssembly::SET_LOCAL_V128: return WebAssembly::SET_LOCAL_V128_S;
> -  case WebAssembly::SHL_I32: return WebAssembly::SHL_I32_S;
> -  case WebAssembly::SHL_I64: return WebAssembly::SHL_I64_S;
> -  case WebAssembly::SHR_S_I32: return WebAssembly::SHR_S_I32_S;
> -  case WebAssembly::SHR_S_I64: return WebAssembly::SHR_S_I64_S;
> -  case WebAssembly::SHR_U_I32: return WebAssembly::SHR_U_I32_S;
> -  case WebAssembly::SHR_U_I64: return WebAssembly::SHR_U_I64_S;
> -  case WebAssembly::SQRT_F32: return WebAssembly::SQRT_F32_S;
> -  case WebAssembly::SQRT_F64: return WebAssembly::SQRT_F64_S;
> -  case WebAssembly::STORE16_I32: return WebAssembly::STORE16_I32_S;
> -  case WebAssembly::STORE16_I64: return WebAssembly::STORE16_I64_S;
> -  case WebAssembly::STORE32_I64: return WebAssembly::STORE32_I64_S;
> -  case WebAssembly::STORE8_I32: return WebAssembly::STORE8_I32_S;
> -  case WebAssembly::STORE8_I64: return WebAssembly::STORE8_I64_S;
> -  case WebAssembly::STORE_F32: return WebAssembly::STORE_F32_S;
> -  case WebAssembly::STORE_F64: return WebAssembly::STORE_F64_S;
> -  case WebAssembly::STORE_I32: return WebAssembly::STORE_I32_S;
> -  case WebAssembly::STORE_I64: return WebAssembly::STORE_I64_S;
> -  case WebAssembly::SUB_F32: return WebAssembly::SUB_F32_S;
> -  case WebAssembly::SUB_F32x4: return WebAssembly::SUB_F32x4_S;
> -  case WebAssembly::SUB_F64: return WebAssembly::SUB_F64_S;
> -  case WebAssembly::SUB_I16x8: return WebAssembly::SUB_I16x8_S;
> -  case WebAssembly::SUB_I32: return WebAssembly::SUB_I32_S;
> -  case WebAssembly::SUB_I32x4: return WebAssembly::SUB_I32x4_S;
> -  case WebAssembly::SUB_I64: return WebAssembly::SUB_I64_S;
> -  case WebAssembly::SUB_I8x16: return WebAssembly::SUB_I8x16_S;
> -  case WebAssembly::TEE_EXCEPT_REF: return WebAssembly::TEE_EXCEPT_REF_S;
> -  case WebAssembly::TEE_F32: return WebAssembly::TEE_F32_S;
> -  case WebAssembly::TEE_F64: return WebAssembly::TEE_F64_S;
> -  case WebAssembly::TEE_I32: return WebAssembly::TEE_I32_S;
> -  case WebAssembly::TEE_I64: return WebAssembly::TEE_I64_S;
> -  case WebAssembly::TEE_LOCAL_EXCEPT_REF: return
> WebAssembly::TEE_LOCAL_EXCEPT_REF_S;
> -  case WebAssembly::TEE_LOCAL_F32: return WebAssembly::TEE_LOCAL_F32_S;
> -  case WebAssembly::TEE_LOCAL_F64: return WebAssembly::TEE_LOCAL_F64_S;
> -  case WebAssembly::TEE_LOCAL_I32: return WebAssembly::TEE_LOCAL_I32_S;
> -  case WebAssembly::TEE_LOCAL_I64: return WebAssembly::TEE_LOCAL_I64_S;
> -  case WebAssembly::TEE_LOCAL_V128: return WebAssembly::TEE_LOCAL_V128_S;
> -  case WebAssembly::TEE_V128: return WebAssembly::TEE_V128_S;
> -  case WebAssembly::THROW_I32: return WebAssembly::THROW_I32_S;
> -  case WebAssembly::THROW_I64: return WebAssembly::THROW_I64_S;
> -  case WebAssembly::TRUNC_F32: return WebAssembly::TRUNC_F32_S;
> -  case WebAssembly::TRUNC_F64: return WebAssembly::TRUNC_F64_S;
> -  case WebAssembly::TRY: return WebAssembly::TRY_S;
> -  case WebAssembly::UNREACHABLE: return WebAssembly::UNREACHABLE_S;
> -  case WebAssembly::XOR_I32: return WebAssembly::XOR_I32_S;
> -  case WebAssembly::XOR_I64: return WebAssembly::XOR_I64_S;
> +#ifndef NDEBUG
> +  // Assert that all registers have been stackified at this point.
> +  for (const MachineBasicBlock &MBB : MF) {
> +    for (const MachineInstr &MI : MBB) {
> +      if (MI.isDebugInstr() || MI.isLabel())
> +        continue;
> +      for (const MachineOperand &MO : MI.explicit_operands()) {
> +        assert(
> +            (!MO.isReg() || MRI.use_empty(MO.getReg()) ||
> +             MFI.isVRegStackified(MO.getReg())) &&
> +            "WebAssemblyExplicitLocals failed to stackify a register
> operand");
> +      }
> +    }
>    }
> +#endif
> +
> +  return Changed;
>  }
>
> Modified: llvm/trunk/lib/Target/WebAssembly/WebAssemblyInstrControl.td
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/WebAssembly/WebAssemblyInstrControl.td?rev=339630&r1=339629&r2=339630&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/Target/WebAssembly/WebAssemblyInstrControl.td (original)
> +++ llvm/trunk/lib/Target/WebAssembly/WebAssemblyInstrControl.td Mon Aug
> 13 16:12:49 2018
> @@ -53,9 +53,9 @@ def BR_TABLE_I32 : NI<(outs), (ins I32:$
>    let TSFlags{0} = 1;
>    let TSFlags{1} = 1;
>  }
> -def BR_TABLE_I32_S : NI<(outs), (ins variable_ops),
> +def BR_TABLE_I32_S : NI<(outs), (ins I32:$index),
>                          [], 1,
> -                        "br_table", 0x0e> {
> +                        "br_table \t$index", 0x0e> {
>    let TSFlags{0} = 1;
>    let TSFlags{1} = 1;
>  }
> @@ -65,9 +65,9 @@ def BR_TABLE_I64 : NI<(outs), (ins I64:$
>    let TSFlags{0} = 1;
>    let TSFlags{1} = 1;
>  }
> -def BR_TABLE_I64_S : NI<(outs), (ins variable_ops),
> +def BR_TABLE_I64_S : NI<(outs), (ins I64:$index),
>                          [], 1,
> -                        "br_table"> {
> +                        "br_table \t$index"> {
>    let TSFlags{0} = 1;
>    let TSFlags{1} = 1;
>  }
>
> Modified: llvm/trunk/lib/Target/WebAssembly/WebAssemblyInstrMemory.td
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/WebAssembly/WebAssemblyInstrMemory.td?rev=339630&r1=339629&r2=339630&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/Target/WebAssembly/WebAssemblyInstrMemory.td (original)
> +++ llvm/trunk/lib/Target/WebAssembly/WebAssemblyInstrMemory.td Mon Aug 13
> 16:12:49 2018
> @@ -57,12 +57,11 @@ let Defs = [ARGUMENTS] in {
>
>  // Defines atomic and non-atomic loads, regular and extending.
>  multiclass WebAssemblyLoad<WebAssemblyRegClass rc, string Name, int
> Opcode> {
> -  let mayLoad = 1 in
>    defm "": I<(outs rc:$dst),
>               (ins P2Align:$p2align, offset32_op:$off, I32:$addr),
>               (outs), (ins P2Align:$p2align, offset32_op:$off),
>               [], !strconcat(Name, "\t$dst, ${off}(${addr})${p2align}"),
> -             !strconcat(Name, "\t${off}${p2align}"), Opcode>;
> +             !strconcat(Name, "\t${off}, ${p2align}"), Opcode>;
>  }
>
>  // Basic load.
> @@ -308,13 +307,12 @@ let Defs = [ARGUMENTS] in {
>
>  // Defines atomic and non-atomic stores, regular and truncating
>  multiclass WebAssemblyStore<WebAssemblyRegClass rc, string Name, int
> Opcode> {
> -  let mayStore = 1 in
>    defm "" : I<(outs),
>                (ins P2Align:$p2align, offset32_op:$off, I32:$addr,
> rc:$val),
>                (outs),
>                (ins P2Align:$p2align, offset32_op:$off), [],
>                !strconcat(Name, "\t${off}(${addr})${p2align}, $val"),
> -              !strconcat(Name, "\t${off}${p2align}"), Opcode>;
> +              !strconcat(Name, "\t${off}, ${p2align}"), Opcode>;
>  }
>  // Basic store.
>  // Note: WebAssembly inverts SelectionDAG's usual operand order.
> @@ -472,12 +470,12 @@ defm CURRENT_MEMORY_I32 : I<(outs I32:$d
>
>  // Grow memory.
>  defm MEMORY_GROW_I32 : I<(outs I32:$dst), (ins i32imm:$flags, I32:$delta),
> -                         (outs), (ins i32imm:$flags),
> +                         (outs), (ins i32imm:$flags, I32:$delta),
>                           [(set I32:$dst,
>                             (int_wasm_memory_grow (i32 imm:$flags),
>                               I32:$delta))],
>                           "memory.grow\t$dst, $flags, $delta",
> -                         "memory.grow\t$flags", 0x3f>,
> +                         "memory.grow\t$flags, $delta", 0x3f>,
>                         Requires<[HasAddr32]>;
>  defm MEM_GROW_I32 : I<(outs I32:$dst), (ins i32imm:$flags, I32:$delta),
>                        (outs), (ins i32imm:$flags),
>
> Modified: llvm/trunk/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp?rev=339630&r1=339629&r2=339630&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp
> (original)
> +++ llvm/trunk/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp Mon Aug
> 13 16:12:49 2018
> @@ -317,6 +317,9 @@ void WebAssemblyPassConfig::addPreEmitPa
>    // converted into a local.
>    addPass(createWebAssemblyFixIrreducibleControlFlow());
>
> +  // Insert explicit get_local and set_local operators.
> +  addPass(createWebAssemblyExplicitLocals());
> +
>    // Do various transformations for exception handling
>    addPass(createWebAssemblyLateEHPrepare());
>
> @@ -334,9 +337,6 @@ void WebAssemblyPassConfig::addPreEmitPa
>    if (getOptLevel() != CodeGenOpt::None)
>      addPass(createWebAssemblyPeephole());
>
> -  // Insert explicit get_local and set_local operators.
> -  addPass(createWebAssemblyExplicitLocals());
> -
>    // Create a mapping from LLVM CodeGen virtual registers to wasm
> registers.
>    addPass(createWebAssemblyRegNumbering());
>  }
>
> Modified: llvm/trunk/test/CodeGen/WebAssembly/address-offsets.ll
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/WebAssembly/address-offsets.ll?rev=339630&r1=339629&r2=339630&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/CodeGen/WebAssembly/address-offsets.ll (original)
> +++ llvm/trunk/test/CodeGen/WebAssembly/address-offsets.ll Mon Aug 13
> 16:12:49 2018
> @@ -1,4 +1,4 @@
> -; RUN: llc < %s -asm-verbose=false -disable-wasm-fallthrough-return-opt
> -wasm-register-codegen-test-mode | FileCheck %s
> +; RUN: llc < %s -asm-verbose=false -disable-wasm-fallthrough-return-opt
> -disable-wasm-explicit-locals | FileCheck %s
>
>  ; Test folding constant offsets and symbols into load and store addresses
> under
>  ; a variety of circumstances.
>
> Modified: llvm/trunk/test/CodeGen/WebAssembly/atomic-mem-consistency.ll
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/WebAssembly/atomic-mem-consistency.ll?rev=339630&r1=339629&r2=339630&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/CodeGen/WebAssembly/atomic-mem-consistency.ll
> (original)
> +++ llvm/trunk/test/CodeGen/WebAssembly/atomic-mem-consistency.ll Mon Aug
> 13 16:12:49 2018
> @@ -1,5 +1,5 @@
>  ; RUN: not llc < %s -asm-verbose=false
> -disable-wasm-fallthrough-return-opt
> -; RUN: llc < %s -asm-verbose=false -disable-wasm-fallthrough-return-opt
> -wasm-register-codegen-test-mode -mattr=+atomics,+sign-ext | FileCheck %s
> +; RUN: llc < %s -asm-verbose=false -disable-wasm-fallthrough-return-opt
> -disable-wasm-explicit-locals -mattr=+atomics,+sign-ext | FileCheck %s
>
>  ; Currently all wasm atomic memory access instructions are sequentially
>  ; consistent, so even if LLVM IR specifies weaker orderings than that, we
>
> Modified: llvm/trunk/test/CodeGen/WebAssembly/atomic-rmw.ll
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/WebAssembly/atomic-rmw.ll?rev=339630&r1=339629&r2=339630&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/CodeGen/WebAssembly/atomic-rmw.ll (original)
> +++ llvm/trunk/test/CodeGen/WebAssembly/atomic-rmw.ll Mon Aug 13 16:12:49
> 2018
> @@ -1,5 +1,5 @@
> -; RUN: not llc < %s -asm-verbose=false
> -disable-wasm-fallthrough-return-opt -wasm-explicit-locals-codegen-test-mode
> -; RUN: llc < %s -asm-verbose=false -disable-wasm-fallthrough-return-opt
> -wasm-register-codegen-test-mode -mattr=+atomics,+sign-ext | FileCheck %s
> +; RUN: not llc < %s -asm-verbose=false
> -disable-wasm-fallthrough-return-opt
> +; RUN: llc < %s -asm-verbose=false -disable-wasm-fallthrough-return-opt
> -disable-wasm-explicit-locals -mattr=+atomics,+sign-ext | FileCheck %s
>
>  ; Test atomic RMW (read-modify-write) instructions are assembled properly.
>
>
> Modified: llvm/trunk/test/CodeGen/WebAssembly/byval.ll
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/WebAssembly/byval.ll?rev=339630&r1=339629&r2=339630&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/CodeGen/WebAssembly/byval.ll (original)
> +++ llvm/trunk/test/CodeGen/WebAssembly/byval.ll Mon Aug 13 16:12:49 2018
> @@ -1,5 +1,5 @@
> -; RUN: llc < %s -asm-verbose=false -disable-wasm-fallthrough-return-opt
> -wasm-register-codegen-test-mode -verify-machineinstrs | FileCheck %s
> -; RUN: llc < %s -asm-verbose=false -disable-wasm-fallthrough-return-opt
> -wasm-register-codegen-test-mode -verify-machineinstrs -fast-isel |
> FileCheck %s
> +; RUN: llc < %s -asm-verbose=false -disable-wasm-fallthrough-return-opt
> -disable-wasm-explicit-locals -verify-machineinstrs | FileCheck %s
> +; RUN: llc < %s -asm-verbose=false -disable-wasm-fallthrough-return-opt
> -disable-wasm-explicit-locals -verify-machineinstrs -fast-isel | FileCheck
> %s
>
>  target datalayout = "e-m:e-p:32:32-i64:64-n32:64-S128"
>  target triple = "wasm32-unknown-unknown"
>
> Modified: llvm/trunk/test/CodeGen/WebAssembly/call.ll
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/WebAssembly/call.ll?rev=339630&r1=339629&r2=339630&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/CodeGen/WebAssembly/call.ll (original)
> +++ llvm/trunk/test/CodeGen/WebAssembly/call.ll Mon Aug 13 16:12:49 2018
> @@ -1,5 +1,5 @@
> -; RUN: llc < %s -asm-verbose=false -disable-wasm-fallthrough-return-opt
> -wasm-explicit-locals-codegen-test-mode -wasm-temporary-workarounds=false |
> FileCheck %s
> -; RUN: llc < %s -asm-verbose=false -disable-wasm-fallthrough-return-opt
> -wasm-explicit-locals-codegen-test-mode -fast-isel -fast-isel-abort=1
> -wasm-temporary-workarounds=false | FileCheck %s
> +; RUN: llc < %s -asm-verbose=false -disable-wasm-fallthrough-return-opt
> -wasm-temporary-workarounds=false | FileCheck %s
> +; RUN: llc < %s -asm-verbose=false -disable-wasm-fallthrough-return-opt
> -fast-isel -fast-isel-abort=1 -wasm-temporary-workarounds=false | FileCheck
> %s
>
>  ; Test that basic call operations assemble as expected.
>
>
> Modified: llvm/trunk/test/CodeGen/WebAssembly/cfg-stackify-eh.ll
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/WebAssembly/cfg-stackify-eh.ll?rev=339630&r1=339629&r2=339630&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/CodeGen/WebAssembly/cfg-stackify-eh.ll (original)
> +++ llvm/trunk/test/CodeGen/WebAssembly/cfg-stackify-eh.ll Mon Aug 13
> 16:12:49 2018
> @@ -1,4 +1,4 @@
> -; RUN: llc < %s -asm-verbose=false -disable-wasm-fallthrough-return-opt
> -wasm-register-codegen-test-mode -disable-block-placement
> -verify-machineinstrs -fast-isel=false
> -machine-sink-split-probability-threshold=0
> -cgp-freq-ratio-to-skip-merge=1000 -exception-model=wasm
> -mattr=+exception-handling | FileCheck %s
> +; RUN: llc < %s -asm-verbose=false -disable-wasm-fallthrough-return-opt
> -disable-wasm-explicit-locals -disable-block-placement
> -verify-machineinstrs -fast-isel=false
> -machine-sink-split-probability-threshold=0
> -cgp-freq-ratio-to-skip-merge=1000 -exception-model=wasm
> -mattr=+exception-handling | FileCheck %s
>
>  target datalayout = "e-m:e-p:32:32-i64:64-n32:64-S128"
>  target triple = "wasm32-unknown-unknown"
>
> Modified: llvm/trunk/test/CodeGen/WebAssembly/cfg-stackify.ll
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/WebAssembly/cfg-stackify.ll?rev=339630&r1=339629&r2=339630&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/CodeGen/WebAssembly/cfg-stackify.ll (original)
> +++ llvm/trunk/test/CodeGen/WebAssembly/cfg-stackify.ll Mon Aug 13
> 16:12:49 2018
> @@ -1,5 +1,5 @@
> -; RUN: llc < %s -asm-verbose=false -disable-wasm-fallthrough-return-opt
> -wasm-register-codegen-test-mode -disable-block-placement
> -verify-machineinstrs -fast-isel=false
> -machine-sink-split-probability-threshold=0
> -cgp-freq-ratio-to-skip-merge=1000 | FileCheck %s
> -; RUN: llc < %s -asm-verbose=false -disable-wasm-fallthrough-return-opt
> -wasm-register-codegen-test-mode -tail-dup-placement=0
> -verify-machineinstrs -fast-isel=false
> -machine-sink-split-probability-threshold=0
> -cgp-freq-ratio-to-skip-merge=1000 | FileCheck -check-prefix=OPT %s
> +; RUN: llc < %s -asm-verbose=false -disable-wasm-fallthrough-return-opt
> -disable-wasm-explicit-locals -disable-block-placement
> -verify-machineinstrs -fast-isel=false
> -machine-sink-split-probability-threshold=0
> -cgp-freq-ratio-to-skip-merge=1000 | FileCheck %s
> +; RUN: llc < %s -asm-verbose=false -disable-wasm-fallthrough-return-opt
> -disable-wasm-explicit-locals -tail-dup-placement=0 -verify-machineinstrs
> -fast-isel=false -machine-sink-split-probability-threshold=0
> -cgp-freq-ratio-to-skip-merge=1000 | FileCheck -check-prefix=OPT %s
>
>  ; Test the CFG stackifier pass.
>
>
> Modified: llvm/trunk/test/CodeGen/WebAssembly/cfi.ll
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/WebAssembly/cfi.ll?rev=339630&r1=339629&r2=339630&view=diff
> ============
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180813/17e873f7/attachment-0001.html>


More information about the llvm-commits mailing list