[PATCH] D50601: llvm-readobj: Fix addend in relocations for android packed format

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 13 16:15:27 PDT 2018


pcc added inline comments.


================
Comment at: lib/Object/ELF.cpp:405-411
       if (GroupHasAddend) {
         if (!GroupedByAddend)
           Addend += ReadSLEB();
         R.r_addend = Addend;
       } else {
         R.r_addend = 0;
       }
----------------
This can be simplified to
```
if (GroupHasAddend && !GroupedByAddend)
  Addend += ReadSLEB();
R.r_addend = Addend;
```


Repository:
  rL LLVM

https://reviews.llvm.org/D50601





More information about the llvm-commits mailing list