[PATCH] D50636: [DAGCombiner] Add X / X -> 1 & X % X -> 0 folds.
Jonas Paulsson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 13 08:34:49 PDT 2018
jonpa added a comment.
In https://reviews.llvm.org/D50636#1197255, @RKSimon wrote:
> In https://reviews.llvm.org/D50636#1197251, @jonpa wrote:
>
> > Not sure if I'm doing something wrong (I use git and tried first patch -p0, and then also with dos2unix, but then that didn't work so I had to write the patch manually although just a few lines...)
>
>
> Sorry - I've never worked out why the upload always screws up my line endings.....
>
> > This did not give any change at all on benchmarks on SystemZ (NFC), and the SystemZ test succeeds with or without the patch...?
>
> Are the x86 tests changing? They contain explicit tests for this fold
Yes, change in x86 test (at least the one I tried)...
Repository:
rL LLVM
https://reviews.llvm.org/D50636
More information about the llvm-commits
mailing list