[PATCH] D50401: [GISel]: Add Opcodes for a few Libm Intrinsics
Amara Emerson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 10 08:54:51 PDT 2018
aemerson added a comment.
I'm a little uneasy about specifying libm in the names of the intrinsics. The langref mentions libm in the description, but the semantics don't exactly match due to ignoring errno. That said, I don't really have a suggestion for a better name, so the only thing I can ask is that we make it a bit more explicit in the documentation what we mean by "LIBM" here.
================
Comment at: include/llvm/Target/GenericOpcodes.td:516
+//------------------------------------------------------------------------------
+// LIBM Intrinsics
+//------------------------------------------------------------------------------
----------------
Perhaps say "LIBM compatible intrinsics"
Repository:
rL LLVM
https://reviews.llvm.org/D50401
More information about the llvm-commits
mailing list