[PATCH] D50512: [MS Demangler] Fix several issues related to templates

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 9 18:20:04 PDT 2018


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: llvm/lib/Demangle/MicrosoftDemangle.cpp:1371
+  auto Number = demangleNumber(MangledName);
+  assert(!Number.second);
 
----------------
This assert is implied by startsWithLocalScopePattern and can't be tripped by corrupt input, right?


https://reviews.llvm.org/D50512





More information about the llvm-commits mailing list