[PATCH] D50512: [MS Demangler] Fix several issues related to templates

[Zachary Turner via Phabricator via llvm-commits]

zturner created this revision.
zturner added reviewers: majnemer, ruiu, rnk.
Herald added subscribers: erik.pilkington, hiraditya.

These were uncovered when porting the mangling tests in ms-templates.cpp from clang/CodeGenCXX over to demangling tests.  The main issues fixed here are surrounding integer literal signed and unsignedness, empty array dimensions, and pointer and reference non-type template parameters.

I'm on Linux right now so I can't run these through `undname` to check what it returns in these cases, but I'm satisfied with our output regardless and it matches up with the original source code.

I'd like to eventually do something "prettier" for the uuid cases, but for now at least it's not wrong.


https://reviews.llvm.org/D50512

Files:
  llvm/lib/Demangle/MicrosoftDemangle.cpp
  llvm/test/Demangle/ms-templates.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D50512.159924.patch
Type: text/x-patch
Size: 16898 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180809/8ba7de65/attachment.bin>