[PATCH] D50466: [DWARF] Verifier now handles .debug_types sections.
Paul Robinson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 8 16:39:42 PDT 2018
probinson marked an inline comment as done.
probinson added inline comments.
================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFVerifier.h:166
+ /// verified successfully, false otherwise.
+ bool verifyUnitSection(const DWARFSection &S, DWARFSectionKind SectionKind);
+
----------------
JDevlieghere wrote:
> I believe we are moving to returning `unsigned`s instead of booleans. I'd do the same here, even if the first error is fatal. Maybe you can do the same for `verifyUnitContents` for consistency?
Done in the commit, coming soon.
Repository:
rL LLVM
https://reviews.llvm.org/D50466
More information about the llvm-commits
mailing list