[PATCH] D50466: [DWARF] Verifier now handles .debug_types sections.

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

Thanks Paul! One nit, otherwise this LGTM.



================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFVerifier.h:166
+  /// verified successfully, false otherwise.
+  bool verifyUnitSection(const DWARFSection &S, DWARFSectionKind SectionKind);
+
----------------
I believe we are moving to returning `unsigned`s instead of booleans. I'd do the same here, even if the first error is fatal. Maybe you can do the same for `verifyUnitContents` for consistency?


Repository:
  rL LLVM

https://reviews.llvm.org/D50466