[PATCH] D50297: On FreeBSD, align AArch64 and i386 image base to superpage

[Dimitry Andric via Phabricator via llvm-commits]

dim added a comment.

In https://reviews.llvm.org/D50297#1189621, @ruiu wrote:

> > Looking at this a bit more, I see that it is unconditionally setting the DefaultImage base for all platforms, which cannot be right. I didn't notice this when it was committed into FreeBSD, but it doesn't matter there, of course. I'm not sure if there is a good way to override this setting on a per-platform basis. Maybe just if (os == FreeBSD) DefaultImageBase=x?
>
> Is there any reason that this value doesn't work for other operating systems? I guess the new image base values work everywhere. If that's the case, I'd change the default so that we have less moving parts in the linker.


I'm not sure if it will work on all OSes, I can't test them all.  In any case, I'll update the test cases first, then update this review.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D50297