[PATCH] D50268: [LLD] [COFF] Remove a superfluous warning about aligncomm for non-common symbols

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 6 10:44:04 PDT 2018


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: test/COFF/common-replacement.s:32-35
+# This produces an aligncomm directive, but when linking in
+# Inputs/common-replacement.s, this symbol is replaced by a normal defined
+# symbol instead.
+        .comm           foo, 4, 2
----------------
Wow, our assembler does that? Crazy. Does gas?


https://reviews.llvm.org/D50268





More information about the llvm-commits mailing list