[PATCH] D50283: Refactor FileCheck to be used as API

Aditya Nandakumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 7 14:52:26 PDT 2018


aditya_nandakumar added a comment.

Thanks for the review. I'll push after renaming the generic names.



================
Comment at: include/llvm/Support/FileCheck.h:45
+
+namespace Check {
+enum CheckType {
----------------
bogner wrote:
> This name is a bit generic for the llvm:: namespace, we should probably use something with FileCheck in the name.
I've renamed the enums and other structs to have the prefix FileCheck in them.


Repository:
  rL LLVM

https://reviews.llvm.org/D50283





More information about the llvm-commits mailing list