[PATCH] D50283: Refactor FileCheck to be used as API

[Justin Bogner via Phabricator via llvm-commits]

bogner accepted this revision.
bogner added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: include/llvm/Support/FileCheck.h:45
+
+namespace Check {
+enum CheckType {
----------------
This name is a bit generic for the llvm:: namespace, we should probably use something with FileCheck in the name.


================
Comment at: include/llvm/Support/FileCheck.h:131
+/// A check that we found in the input file.
+struct CheckString {
+  /// The pattern to match.
----------------
Same here.

It's a bit sad that these types need to be visible in the header, but it's kind of hard to avoid without doing something quite a bit more awkward so I guess it makes sense.


Repository:
  rL LLVM

https://reviews.llvm.org/D50283