[PATCH] D50402: [SelectionDAG][X86] Reorder the operands the MaskedStoreSDNode to put the value first.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 7 12:13:31 PDT 2018


craig.topper created this revision.
craig.topper added reviewers: RKSimon, delena, hfinkel.

Previously the value being stored is the last operand in SDNode. This causes the type legalizer to visit the mask operand before the value operand. The type legalizer was more complicated because of this since we want the type of the value to drive the decisions.

This patch moves the value to be the first operand so we visit it first during type legalization. It also simplifies the type legalization code accordingly.

X86 is currently the only in tree target that uses this SDNode. Not sure if there are any users out of tree.


https://reviews.llvm.org/D50402

Files:
  include/llvm/CodeGen/SelectionDAGNodes.h
  include/llvm/Target/TargetSelectionDAG.td
  lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp
  lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp
  lib/CodeGen/SelectionDAG/SelectionDAG.cpp
  lib/Target/X86/X86ISelLowering.cpp
  lib/Target/X86/X86ISelLowering.h
  lib/Target/X86/X86InstrAVX512.td
  lib/Target/X86/X86InstrSSE.td

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D50402.159566.patch
Type: text/x-patch
Size: 13287 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180807/756a2f2b/attachment.bin>


More information about the llvm-commits mailing list