[PATCH] D50222: [CodeGen] [SelectionDAG] More efficient code for X % C == 0

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 5 10:13:27 PDT 2018


lebedev.ri added a comment.

In https://reviews.llvm.org/D50222#1188879, @hermord wrote:

> @majnemer Thanks; this was, in fact, incorrect. Now, to simplify the logic, the absolute value of D is taken and lshr is used.


There were non-NFC changes to the code, but there was no test changes at all.
I suspect the test coverage is seriously lacking.


Repository:
  rL LLVM

https://reviews.llvm.org/D50222





More information about the llvm-commits mailing list