[PATCH] D50232: Fix modules build with different technique to suppress Knuth debugging
    Kristina Brooks via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Fri Aug  3 16:27:54 PDT 2018
    
    
  
kristina added a comment.
The original version (the one you linked for https://reviews.llvm.org/D40404 without push/pop) does indeed look better, I haven't reviewed or tested it, but it seems others have so I'd say go for that one. Would probably be the best approach.
Repository:
  rL LLVM
https://reviews.llvm.org/D50232
    
    
More information about the llvm-commits
mailing list