[PATCH] D50232: Fix modules build with different technique to suppress Knuth debugging

Kristina Brooks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 3 16:23:32 PDT 2018


kristina added a comment.

Personal style preference but I think `#define DEBUG_KNUTH(X) do {} while(false)` on one line would be better as well instead of splitting it across three lines as well. It's how a lot of them are defined in headers in `libLLVMSupport`.


Repository:
  rL LLVM

https://reviews.llvm.org/D50232





More information about the llvm-commits mailing list