[PATCH] D50268: [LLD] [COFF] Remove a superfluous warning about aligncomm for non-common symbols
Martin Storsjö via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 3 14:06:36 PDT 2018
mstorsjo added a comment.
In https://reviews.llvm.org/D50268#1187936, @rnk wrote:
> Shouldn't be hard to make a test with .s files.
Yup, that's easily done - it's easy to write a testcase which reproduces this thing. I can make it test for some general mechanisms of the replacement of common symbols by defined data (although I guess there are other such tests already?), but checking explicitly that the warning we just removed isn't output seems silly though.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D50268
More information about the llvm-commits
mailing list