[PATCH] D50268: [LLD] [COFF] Remove a superfluous warning about aligncomm for non-common symbols

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

Shouldn't be hard to make a test with .s files.



================
Comment at: COFF/Driver.cpp:1428
     auto *DC = dyn_cast<DefinedCommon>(Sym);
-    if (!DC) {
-      warn("/aligncomm symbol " + Name + " of wrong kind");
+    if (!DC)
       continue;
----------------
The description in your commit message would make a good comment here, i.e. "If the symbol isn't common, it must have been replaced with a regular symbol, which will carry its own alignment."


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D50268