[PATCH] D50212: [X86] Remove RELEASE_ and ACQUIRE_ pseudo instructions. Use isel patterns and the normal instructions instead
JF Bastien via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 3 08:36:52 PDT 2018
jfb requested changes to this revision.
jfb added inline comments.
This revision now requires changes to proceed.
================
Comment at: test/CodeGen/X86/atomic_mi.ll:1725
+; X64-NEXT: movd %xmm1, %eax
+; X64-NEXT: movl %eax, (%rdi)
; X64-NEXT: retq
----------------
This seems undesirable to remove. I don't understand the justification you have for getting rid of it. Ditto all the other FP changes. Please separate FP changes from the cleanup you're trying to achieve.
https://reviews.llvm.org/D50212
More information about the llvm-commits
mailing list