[PATCH] D50126: [Support] fix TempFile infinite loop and permission denied errors

[Bob Haarman via Phabricator via llvm-commits]

inglorion added a comment.

Sorry, Peter. Saw your reply after I had already pushed the change. Would:

  // Limit the number of attempts we make, so that we don't infinite loop. E.g.
  // "permission denied" could be for a specific file (so we retry with a
  // different name) or for the whole directory (retry would always fail).
  // Checking which is racy, so we try a number of times, then give up.

be a better comment? If so, I'll land that as a follow-up.


Repository:
  rL LLVM

https://reviews.llvm.org/D50126