[PATCH] D50126: [Support] fix TempFile infinite loop and permission denied errors

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: llvm/lib/Support/Path.cpp:194
+  // Limit the number of attempts we make, so that we don't infinite loop when
+  // we run out of filenames that fit the model.
+  std::error_code EC;
----------------
This is unlikely to be the problem given the number of % characters typically in a model. It's more likely to be the case that we're getting permission denied because we don't actually have permission. That's what I'd say in the comment here.


Repository:
  rL LLVM

https://reviews.llvm.org/D50126