[PATCH] D50070: [X86] Improved sched models for X86 CMPXCHG* instructions

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 1 09:39:26 PDT 2018


craig.topper added inline comments.


================
Comment at: lib/Target/X86/X86InstrInfo.td:2083
 
-let SchedRW = [WriteALULd, WriteRMW], mayLoad = 1, mayStore = 1,
+let SchedRW = [WriteCMPXCHGLd, WriteRMW], mayLoad = 1, mayStore = 1,
     hasSideEffects = 0 in {
----------------
If I remember right from arithmetic instructions, this doesn't make the latency additive the way it should be. This should probably be just WriteCMPXCHGRMW implemented as a WriteSequence like we do for WriteALURMW


https://reviews.llvm.org/D50070





More information about the llvm-commits mailing list