[PATCH] D50127: [Support] use larger character set for creating unique filenames

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 31 21:11:57 PDT 2018


zturner added a subscriber: inglorion.
zturner added a comment.

It would be an extra line of code, but I think this would be clearer (with
even less chance of collision) if you just choose a random number in [0,35]
and map it to [0-9][a-z]. The bit twiddling and array indexing seems like
unnecessary cleverness and someone could accidentally come along and break
it if they weren’t careful.


https://reviews.llvm.org/D50127





More information about the llvm-commits mailing list