[PATCH] D50127: [Support] use larger character set for creating unique filenames

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 31 21:11:42 PDT 2018


It would be an extra line of code, but I think this would be clearer (with
even less chance of collision) if you just choose a random number in [0,35]
and map it to [0-9][a-z]. The bit twiddling and array indexing seems like
unnecessary cleverness and someone could accidentally come along and break
it if they weren’t careful.
On Tue, Jul 31, 2018 at 8:25 PM Bob Haarman via Phabricator <
reviews at reviews.llvm.org> wrote:

> inglorion added a comment.
>
> The inspiration for this is http://crbug.com/856635, where we're seeing
> the same file name generated multiple times during a single run.
>
>
> https://reviews.llvm.org/D50127
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180731/adc33cc0/attachment.html>


More information about the llvm-commits mailing list