[PATCH] D49676: [DWARF] support for .debug_addr (consumer)

Victor Leschuk via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 31 14:43:59 PDT 2018


vleschuk added inline comments.


================
Comment at: include/llvm/DebugInfo/DIContext.h:158
+  uint16_t Version = 0; // DWARF version to assume when extracting.
+  uint8_t AddrSize = 4; // Address byte size to assume when extracting.
   bool ShowAddresses = true;
----------------
aprantl wrote:
> Why is this a property of the dump options and not of whatever object that is being dumped?
I agree with the comment above about version, but address size should be the same for every section, am I right?


https://reviews.llvm.org/D49676





More information about the llvm-commits mailing list