[PATCH] D49676: [DWARF] support for .debug_addr (consumer)

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

Sorry about the late reply, I've been on vacation.



================
Comment at: include/llvm/DebugInfo/DIContext.h:157
   unsigned RecurseDepth = -1U;
+  uint16_t Version = 0; // DWARF version to assume when extracting.
+  uint8_t AddrSize = 4; // Address byte size to assume when extracting.
----------------
This looks like the wrong place to store this. Many dwarf sections have version numbers that are independent form one another. For example on Darwin we often use dwarf 4 debug_info and dwarf 2 debug_line in the same file.


================
Comment at: include/llvm/DebugInfo/DIContext.h:158
+  uint16_t Version = 0; // DWARF version to assume when extracting.
+  uint8_t AddrSize = 4; // Address byte size to assume when extracting.
   bool ShowAddresses = true;
----------------
Why is this a property of the dump options and not of whatever object that is being dumped?


https://reviews.llvm.org/D49676