[PATCH] D50017: ELF: Add libcall symbols to the link when LTO is being used.
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 31 11:46:30 PDT 2018
ruiu added a comment.
LGTM
> 2. The set of libcall symbols is a property of the code generator linked into lld, not the one that was used to create the bitcode file. That means that if we see an old bitcode file it would not be correct to use its libcall symbols.
I'm convinced. A concern I had was that the symbol names are not a property of lld but LTO, but lld and LTO are a single program, and by its nature the symbol name list we have here in lld cannot be out of sync with LTO.
Repository:
rL LLVM
https://reviews.llvm.org/D50017
More information about the llvm-commits
mailing list