[PATCH] D50017: ELF: Add libcall symbols to the link when LTO is being used.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 31 11:41:42 PDT 2018


pcc added a comment.

I thought about that but decided against it for a few reasons:

1. It seemed best to express what we want to happen directly. Putting the symbols in the object files seemed like a more round-about way of fixing the bug.
2. The set of libcall symbols is a property of the code generator linked into lld, not the one that was used to create the bitcode file. That means that if we see an old bitcode file it would not be correct to use its libcall symbols.
3. It would bloat every bitcode file with the same (potentially incorrect due to 2) content when that can be easily avoided.


Repository:
  rL LLVM

https://reviews.llvm.org/D50017





More information about the llvm-commits mailing list