[PATCH] D49744: [DebugInfo/DWARF] [4/4] De-segregate type units and compile units. NFC

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFUnit.cpp:101
+    if (I != this->end() &&
+        (&(*I)->getInfoSection() != &Section || (*I)->getOffset() == Offset)) {
       ++I;
----------------
Side note:I find this loop to be a bit hard to follow... but it's been this way since before you touched it.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFUnit.cpp:107
     if (!U)
       break;
     Offset = U->getNextUnitOffset();
----------------
might be nice to comment what the `break` means (did the parsing fail, are we at the end?).


https://reviews.llvm.org/D49744