[PATCH] D49744: [DebugInfo/DWARF] [4/4] De-segregate type units and compile units. NFC

[Paul Robinson via Phabricator via llvm-commits]

probinson marked 3 inline comments as done.
probinson added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFContext.cpp:555
 DWARFCompileUnit *DWARFContext::getDWOCompileUnitForHash(uint64_t Hash) {
-  if (DWOCUs.empty())
-    DWOCUs.parseDWO(*this, DObj->getInfoDWOSection(), DW_SECT_INFO, true);
+  parseDWOUnits(/* Lazy= */ true);
 
----------------
probinson wrote:
> JDevlieghere wrote:
> > I recently learned about this "trick" where you define an enum like `enum { parseLazy = true };`. Not sure if it's worth it here but I (personally) think it's nicer than the comment. 
> I can do something along those lines.
Oops forgot this one.  Will try again before committing.


https://reviews.llvm.org/D49744