[PATCH] D50020: [X86] Preserve more liveness information in emitStackProbeInline

[Matthias Braun via Phabricator via llvm-commits]

MatzeB accepted this revision.
MatzeB added a comment.
This revision is now accepted and ready to land.

Thanks for fixing machine verifier errors, LGTM.

> PR38376

You can put `https://llvm.org/PR38376` into the commit message so it becomes a clickable link in some terminal emulators or e-mail clients.



================
Comment at: lib/Target/X86/X86FrameLowering.cpp:619-621
+    // Check if we need to spill RCX and/or RDX.
+    const bool IsRCXLiveIn = MBB.isLiveIn(X86::RCX);
+    const bool IsRDXLiveIn = MBB.isLiveIn(X86::RDX);
----------------
Can you explicitely state the assumption that no earlier prolog instruction changes RCX/RDX so that checking the block live-ins is enough?


https://reviews.llvm.org/D50020