[PATCH] D49778: Fix "Q" and "R" inline assembly template modifiers for big-endian Arm

[Eric Christopher via Phabricator via llvm-commits]

echristo added a comment.

Couple of comments.



================
Comment at: lib/Target/ARM/ARMAsmPrinter.cpp:365
       InlineAsm::hasRegClassConstraint(Flags, RC);
+      if (ExtraCode[0] == 'Q') {
+        FirstHalf = ATM.isLittleEndian();
----------------
Nit: single statements aren't braced in llvm.


================
Comment at: lib/Target/ARM/ARMAsmPrinter.cpp:365
       InlineAsm::hasRegClassConstraint(Flags, RC);
+      if (ExtraCode[0] == 'Q') {
+        FirstHalf = ATM.isLittleEndian();
----------------
echristo wrote:
> Nit: single statements aren't braced in llvm.
Block comment explaining why and how this affects things.


Repository:
  rL LLVM

https://reviews.llvm.org/D49778