[PATCH] D49938: [ELF] Update ld.lld.1

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 30 13:19:26 PDT 2018


ruiu added inline comments.


================
Comment at: docs/ld.lld.1:39
 for shared libraries if used.
-.It Fl -auxiliary Ns = Ns Ar value
+.It Fl -auxiliary Ar value
 Set the
----------------
MaskRay wrote:
> ruiu wrote:
> > Why did you remove "="?
> https://github.com/freebsd/freebsd/blob/4b26291ed887f8245f4c355f224743bfde7120f7/usr.bin/clang/lld/ld.lld.1#L70 uses this form but there are also other places preferring `option=bar`.
> 
> If you think `=` is better than a space, I can change all of them (`Eq` options) to use `=`.
The GNU's convention seems to always add `=` for long options that take arguments. I'd follow that convention, but can you leave them alone for now?

I think you changed too many things in a single patch. Can you do that step by step? I'd revert all but the change to add missing options.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D49938





More information about the llvm-commits mailing list