[PATCH] D49938: [ELF] Update ld.lld.1

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 30 13:09:35 PDT 2018


MaskRay marked an inline comment as done.
MaskRay added inline comments.


================
Comment at: docs/ld.lld.1:39
 for shared libraries if used.
-.It Fl -auxiliary Ns = Ns Ar value
+.It Fl -auxiliary Ar value
 Set the
----------------
ruiu wrote:
> Why did you remove "="?
https://github.com/freebsd/freebsd/blob/4b26291ed887f8245f4c355f224743bfde7120f7/usr.bin/clang/lld/ld.lld.1#L70 uses this form but there are also other places preferring `option=bar`.

If you think `=` is better than a space, I can change all of them (`Eq` options) to use `=`.


================
Comment at: docs/ld.lld.1:410
+Verbose mode.
+.It Fl -version , Fl V
+Display the version number and exit.
----------------
ruiu wrote:
> Why did you swap the order?
The long option `--version` is used as the key here for alphabetical sorting. `--version` should be ordered before `--version-script` so their orders are swapped.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D49938





More information about the llvm-commits mailing list