[PATCH] D49900: [GlobalISel] Add a G_BLOCK_ADDR opcode to handle IR blockaddress constants.
Amara Emerson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 30 11:14:36 PDT 2018
aemerson added inline comments.
================
Comment at: include/llvm/CodeGen/GlobalISel/MachineIRBuilder.h:952
+ /// \pre \p Res must be a generic virtual register of a pointer type.
+ /// \pre \p BA must be an IR block address value.
+ ///
----------------
rtereshin wrote:
> If this is evident from the operand type I'd drop the comment. Could a `BlockAddress` be something else, not "an IR block address value"?
> Just a nitpick, not blocking.
True, it's a bit redundant.
Repository:
rL LLVM
https://reviews.llvm.org/D49900
More information about the llvm-commits
mailing list