[PATCH] D49900: [GlobalISel] Add a G_BLOCK_ADDR opcode to handle IR blockaddress constants.

[Roman Tereshin via Phabricator via llvm-commits]

rtereshin accepted this revision.
rtereshin added a comment.
This revision is now accepted and ready to land.

Besides a nitpick, LGTM



================
Comment at: include/llvm/CodeGen/GlobalISel/MachineIRBuilder.h:952
+  /// \pre \p Res must be a generic virtual register of a pointer type.
+  /// \pre \p BA must be an IR block address value.
+  ///
----------------
If this is evident from the operand type I'd drop the comment. Could a `BlockAddress` be something else, not "an IR block address value"?
Just a nitpick, not blocking.


Repository:
  rL LLVM

https://reviews.llvm.org/D49900