[PATCH] D49778: Fix "Q" and "R" inline assembly template modifiers for big-endian Arm

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre added inline comments.


================
Comment at: lib/Target/ARM/ARMAsmPrinter.cpp:365-370
+      if (ExtraCode[0] == 'Q') {
+	FirstHalf = ATM.isLittleEndian();
+      } else {
+        // ExtraCode[0] == 'R'.
+        FirstHalf = !ATM.isLittleEndian();
+      }
----------------
Alternatively: FirstHalf = (ExtraCode[0] == 'Q') == ATM.isLittleEndian(), your call on whether this is clearer or not to read.


================
Comment at: lib/Target/ARM/ARMAsmPrinter.cpp:366
+      if (ExtraCode[0] == 'Q') {
+	FirstHalf = ATM.isLittleEndian();
+      } else {
----------------
Indentation looks off here.


Repository:
  rL LLVM

https://reviews.llvm.org/D49778