[PATCH] D49829: [X86] Add pattern matching for PMADDUBSW

Zvi Rackover via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 27 12:58:06 PDT 2018

Previous message: [PATCH] D49829: [X86] Add pattern matching for PMADDUBSW
Next message: [llvm] r337986 - CodeGen: Cleanup regmask construction; NFC
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

zvi added a comment.

LGTM. Regarding the SSE2->SSSE3 test change, i think it's fine. Can you update the --check-prefix to SSSE3 in a follow-up commit? I think it's convenient to review as-is, but in the longer term it would be misleading to leave it as-is.


https://reviews.llvm.org/D49829

Previous message: [PATCH] D49829: [X86] Add pattern matching for PMADDUBSW
Next message: [llvm] r337986 - CodeGen: Cleanup regmask construction; NFC
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list