[PATCH] D49639: [MS Demangler] Demangle pointers to member functions

[Zachary Turner via Phabricator via llvm-commits]

zturner added inline comments.


================
Comment at: llvm/test/Demangle/ms-mangle.test:102
+?l@@3P8foo@@AEHH at ZQ1@
+; CHECK: int __thiscall (foo::*l)(int)
 
----------------
rnk wrote:
> Is there a way to get the calling convention inside the parentheses? Undname produces names like:
> Undecoration of :- "?memptrtofun5@@3P8B@@EAA?CHXZEQ1@"
> is :- "int volatile (__cdecl B::* __ptr64 memptrtofun5)(void) __ptr64"
> 
> I believe that's where you have to write the calling convention if you want it to parse.
> 
> If it's too difficult to do in this patch, that's fine.
I have this working in a followup patch, but it pollutes this patch a bit too much IMO, so after I get this and the others in, I'll submit that in a followup.  That said, I still need to update this patch to print the grammatically legal form of a member function pointer, so I'll update this patch soon with that piece, and do the calling convention part later.


https://reviews.llvm.org/D49639