[PATCH] D49639: [MS Demangler] Demangle pointers to member functions

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 26 12:54:17 PDT 2018


rnk added inline comments.


================
Comment at: llvm/lib/Demangle/MicrosoftDemangle.cpp:1295
+Type *Demangler::demangleFunctionEncoding() {
+  FuncClass FC = (FuncClass)demangleFunctionClass();
+
----------------
Don't need this cast anymore


================
Comment at: llvm/test/Demangle/ms-mangle.test:102
+?l@@3P8foo@@AEHH at ZQ1@
+; CHECK: int __thiscall (foo::*l)(int)
 
----------------
Is there a way to get the calling convention inside the parentheses? Undname produces names like:
Undecoration of :- "?memptrtofun5@@3P8B@@EAA?CHXZEQ1@"
is :- "int volatile (__cdecl B::* __ptr64 memptrtofun5)(void) __ptr64"

I believe that's where you have to write the calling convention if you want it to parse.

If it's too difficult to do in this patch, that's fine.


https://reviews.llvm.org/D49639





More information about the llvm-commits mailing list