[PATCH] D49605: AMDGPU: Fix implementation of isCanonicalized

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: lib/Target/AMDGPU/SIISelLowering.cpp:6784
+      if (Subtarget->supportsMinMaxDenormModes() ||
+          denormalsEnabledForType(Op.getValueType()))
+        return true;
----------------
arsenm wrote:
> rampitec wrote:
> > I think you are missing DAG.isKnownNeverNaN() condition.
> No, I think this is correct. It doesn't matter if there is a nan input since an snan will be correctly quieted
Hmm.. That sounds right.


https://reviews.llvm.org/D49605