[PATCH] D49605: AMDGPU: Fix implementation of isCanonicalized
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 26 12:11:37 PDT 2018
arsenm added inline comments.
================
Comment at: lib/Target/AMDGPU/SIISelLowering.cpp:6784
+ if (Subtarget->supportsMinMaxDenormModes() ||
+ denormalsEnabledForType(Op.getValueType()))
+ return true;
----------------
rampitec wrote:
> I think you are missing DAG.isKnownNeverNaN() condition.
No, I think this is correct. It doesn't matter if there is a nan input since an snan will be correctly quieted
https://reviews.llvm.org/D49605
More information about the llvm-commits
mailing list