[PATCH] D43515: More math intrinsics for conservative math handling

[Kevin P. Neal via Phabricator via llvm-commits]

kpn added inline comments.


================
Comment at: lib/CodeGen/StrictFP.cpp:171
+
+  auto *t = cast<IntegerType>(I->getType());
+  APInt IntMaxAP(APInt::getSignedMinValue(DL->getTypeStoreSize(t) * 8));
----------------
craig.topper wrote:
> kpn wrote:
> > craig.topper wrote:
> > > What if the intrinsic uses a vector type?
> > It would have been caught by the IR verifier. A vector would have been rejected there.
> I don't see where the IR verifier rejects vectors. I just see that it checks that element counts are equal. And why should it reject vectors? We need to support fptosi/fptoui for vectors.
It doesn't reject them, now. This latest patch added support for vectors. My inexperience with Phabricator lost the comment that said that.


https://reviews.llvm.org/D43515