[PATCH] D43515: More math intrinsics for conservative math handling

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: lib/CodeGen/StrictFP.cpp:171
+
+  auto *t = cast<IntegerType>(I->getType());
+  APInt IntMaxAP(APInt::getSignedMinValue(DL->getTypeStoreSize(t) * 8));
----------------
kpn wrote:
> craig.topper wrote:
> > What if the intrinsic uses a vector type?
> It would have been caught by the IR verifier. A vector would have been rejected there.
I don't see where the IR verifier rejects vectors. I just see that it checks that element counts are equal. And why should it reject vectors? We need to support fptosi/fptoui for vectors.


https://reviews.llvm.org/D43515