[PATCH] D49836: AMDGPU: Remove broken ternary i16 patterns

Jan Vesely via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 25 23:55:34 PDT 2018


jvesely created this revision.
jvesely added reviewers: arsenm, tstellar.
Herald added subscribers: t-tye, tpr, dstuttard, yaxunl, nhaehnle, wdng, kzhuravl.

Fixup test to check for GCN prefix
These patterns always zero extend the result even though it might need sign extension.
This has been broken since the addition of i16 support.
It has popped up in mad_sat(char) test since min(max()) combination is turned into v_med3, resulting in the following (incorrect) sequence:

  v_mad_i16 v2, v10, v9, v11
  v_med3_i32 v2, v2, v8, v7

Fixes mad_sat(char) piglit  on VI.


Repository:
  rL LLVM

https://reviews.llvm.org/D49836

Files:
  lib/Target/AMDGPU/VOP3Instructions.td
  test/CodeGen/AMDGPU/mad_uint24.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49836.157426.patch
Type: text/x-patch
Size: 6067 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180726/e7436090/attachment.bin>


More information about the llvm-commits mailing list