[PATCH] D49598: [SystemZ] Use tablegen loops in SchedModels

Ulrich Weigand via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 25 03:26:27 PDT 2018


uweigand added a comment.

Sorry, missed your last update.

I'm not sure clang-format understands .td files well.  This case:

  foreach L = 1 - 16 in def "WLat"#L#"LSU"
    : WriteSequence<[ !cast<SchedWrite>("WLat"#L), LSULatency ]>;

does indeed look a bit weird, I'd probably write something like:

  foreach L = 1 - 16 in
    def "WLat"#L#"LSU" : WriteSequence<[ !cast<SchedWrite>("WLat"#L), LSULatency ]>;


https://reviews.llvm.org/D49598





More information about the llvm-commits mailing list